From: Matt Turner <mattst88@gmail.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-alpha@vger.kernel.org,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
kernel@gpiccoli.net, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v4] alpha: Clean-up the panic notifier code
Date: Mon, 13 Mar 2023 16:39:55 -0400 [thread overview]
Message-ID: <CAEdQ38HS=V9QJsdSoccos02HGn4=QKobkci=BTP9tc3=RyzUFQ@mail.gmail.com> (raw)
In-Reply-To: <ba225af5-3729-32a4-318a-c1c4b8e8b37a@igalia.com>
On Mon, Mar 13, 2023 at 4:18 PM Guilherme G. Piccoli
<gpiccoli@igalia.com> wrote:
>
> On 20/02/2023 18:22, Guilherme G. Piccoli wrote:
> > The alpha panic notifier has some code issues, not following
> > the conventions of other notifiers. Also, it might halt the
> > machine but still it is set to run as early as possible, which
> > doesn't seem to be a good idea.
> >
> > So, let's clean the code and set the notifier to run as the
> > latest, following the same approach other architectures are
> > doing - also, remove the unnecessary include of a header already
> > included indirectly.
> >
> > Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> > Cc: Matt Turner <mattst88@gmail.com>
> > Cc: Richard Henderson <richard.henderson@linaro.org>
> > Reviewed-by: Petr Mladek <pmladek@suse.com>
> > Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> >
> > ---
> >
> >
> > V4:
> > - Rebased (and build-tested) against v6.2.
> >
> > V3:
> > - No changes.
> >
> > V2:
> > - Fixed rth email address;
> > - Added Petr's review tag - thanks!
> >
>
> Hi folks, just a gentle ping.
> Lemme know if there's anything I could do in order to get this move forward.
>
> Thanks in advance,
>
>
> Guilherme
My apologies. I meant to include this in my last pull request.
I'll take it through my tree.
Thanks,
Matt
next prev parent reply other threads:[~2023-03-13 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 21:22 [PATCH v4] alpha: Clean-up the panic notifier code Guilherme G. Piccoli
2023-03-13 20:18 ` Guilherme G. Piccoli
2023-03-13 20:39 ` Matt Turner [this message]
2023-03-13 20:57 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEdQ38HS=V9QJsdSoccos02HGn4=QKobkci=BTP9tc3=RyzUFQ@mail.gmail.com' \
--to=mattst88@gmail.com \
--cc=gpiccoli@igalia.com \
--cc=ink@jurassic.park.msu.ru \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).