From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: <srinivas.kandagatla@linaro.org>, <neil.armstrong@linaro.org>,
<khilman@baylibre.com>, <jbrunet@baylibre.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmem: meson-mx-efuse: Remove nvmem_device from efuse struct
Date: Tue, 12 Mar 2024 21:42:36 +0530 [thread overview]
Message-ID: <792e956f-eefb-3d2b-ada2-0eaa175ba81e@quicinc.com> (raw)
In-Reply-To: <CAFBinCC2n+Muu2qaAG0PWFj6f+bVFDtHnzm78jSpeodTD47TOg@mail.gmail.com>
Hi Martin,
On 3/8/2024 2:26 AM, Martin Blumenstingl wrote:
> Hello Mukesh,
>
> On Tue, Mar 5, 2024 at 7:58 AM Mukesh Ojha <quic_mojha@quicinc.com> wrote:
>>
>> nvmem_device is used at one place while registering nvmem
>> device and it is not required to be present in efuse struct
>> for just this purpose.
>>
>> Drop nvmem_device and manage with nvmem device stack variable.
> I'm generally fine with this approach
Thanks.
Sorry for the late reply, was on vacation.
>
> [...]
>> @@ -223,9 +222,9 @@ static int meson_mx_efuse_probe(struct platform_device *pdev)
>> return PTR_ERR(efuse->core_clk);
>> }
>>
>> - efuse->nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
>> + nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
> But this doesn't compile for me:
> CC drivers/nvmem/meson-mx-efuse.o
> ../drivers/nvmem/meson-mx-efuse.c: In function 'meson_mx_efuse_probe':
> ../drivers/nvmem/meson-mx-efuse.c:252:9: error: 'nvmem' undeclared
> (first use in this function)
> 252 | nvmem = devm_nvmem_register(&pdev->dev, &efuse->config);
Sent too soon., change was cached never got commited..
v2:
https://lore.kernel.org/lkml/1710259663-14095-1-git-send-email-quic_mojha@quicinc.com/
Thanks,
-Mukesh
>
>
> Best regards,
> Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2024-03-12 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 6:58 [PATCH] nvmem: meson-mx-efuse: Remove nvmem_device from efuse struct Mukesh Ojha
2024-03-07 20:56 ` Martin Blumenstingl
2024-03-12 16:12 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=792e956f-eefb-3d2b-ada2-0eaa175ba81e@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).