From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 19/21] drm/meson: Allow build with COMPILE_TEST=y
Date: Mon, 8 Apr 2024 19:23:18 +0200 [thread overview]
Message-ID: <CAFBinCAE_6RWikgpgBxhkq2pMyMiSSn2kYRKoG0+xfGtdRQiGQ@mail.gmail.com> (raw)
In-Reply-To: <20240408170426.9285-20-ville.syrjala@linux.intel.com>
On Mon, Apr 8, 2024 at 7:05 PM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow meson to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: linux-amlogic@lists.infradead.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thank you for spotting this Ville!
> ---
> drivers/gpu/drm/meson/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/Kconfig b/drivers/gpu/drm/meson/Kconfig
> index 5520b9e3f010..d8f67bd9c755 100644
> --- a/drivers/gpu/drm/meson/Kconfig
> +++ b/drivers/gpu/drm/meson/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_MESON
> tristate "DRM Support for Amlogic Meson Display Controller"
> - depends on DRM && OF && (ARM || ARM64)
> + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
Neil, I wonder if we should just have "depends on DRM && OF" here as
the next line already has:
> depends on ARCH_MESON || COMPILE_TEST
ARCH_MESON is only defined for ARM and ARM64
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2024-04-08 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240408170426.9285-1-ville.syrjala@linux.intel.com>
2024-04-08 17:04 ` [PATCH 19/21] drm/meson: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-08 17:23 ` Martin Blumenstingl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCAE_6RWikgpgBxhkq2pMyMiSSn2kYRKoG0+xfGtdRQiGQ@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).