Linux-api Archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] Enable two testcases in kselftest
@ 2015-11-14  6:01 Bamvor Jian Zhang
       [not found] ` <1447480914-14834-1-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Bamvor Jian Zhang @ 2015-11-14  6:01 UTC (permalink / raw
  To: linux-api-u79uwXL29TY76Z2rM5mHXA
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, khilman-QSEj5FYQhm4dnm+yROfE0A,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A,
	broonie-DgEjT+Ai2ygdnm+yROfE0A, Bamvor Jian Zhang

Capabilities and ipc exist in selftest but is not enabled in the top
level Makefile. I do not know whether it is intended to.

It seems that both of them are tiny tests. These patches try to enable
them and make them build successful in cross compiling environment.

Bamvor Jian Zhang (3):
  selftests/capabilities: align the usage of CFLAGS with others
  selftests/capabilities: actually test it
  selftest/ipc: actually test it

 tools/testing/selftests/Makefile              | 2 ++
 tools/testing/selftests/capabilities/Makefile | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.1.4

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others
       [not found] ` <1447480914-14834-1-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2015-11-14  6:01   ` Bamvor Jian Zhang
       [not found]     ` <1447480914-14834-2-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  2015-11-14  6:01   ` [PATCH 2/3] selftests/capabilities: actually test it Bamvor Jian Zhang
  2015-11-14  6:01   ` [PATCH 3/3] selftest/ipc: " Bamvor Jian Zhang
  2 siblings, 1 reply; 10+ messages in thread
From: Bamvor Jian Zhang @ 2015-11-14  6:01 UTC (permalink / raw
  To: linux-api-u79uwXL29TY76Z2rM5mHXA
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, khilman-QSEj5FYQhm4dnm+yROfE0A,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A,
	broonie-DgEjT+Ai2ygdnm+yROfE0A, Bamvor Jian Zhang

User need to provide cap-ng.h and libcap-ng.so for cross compiling
which could be done by pass extra cflags to EXTRA_CLAGS. But other
testcases pass CFLAGS instead.

Change CLAGS ':=' to CLAGS '+=' to align with others. Delete useless
EXTRA_CLAGS at the same time.

Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 tools/testing/selftests/capabilities/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile
index 8c8f0c1..47337fb 100644
--- a/tools/testing/selftests/capabilities/Makefile
+++ b/tools/testing/selftests/capabilities/Makefile
@@ -7,7 +7,7 @@ include ../lib.mk
 TARGETS := validate_cap test_execve
 TEST_PROGS := test_execve
 
-CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
+CFLAGS += -O2 -g -std=gnu99 -Wall -lcap-ng
 
 all: $(TARGETS)
 
@@ -15,4 +15,4 @@ clean:
 	$(RM) $(TARGETS)
 
 $(TARGETS): %: %.c
-	$(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
+	$(CC) -o $@ $(CFLAGS) $^ -lrt -ldl
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] selftests/capabilities: actually test it
       [not found] ` <1447480914-14834-1-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  2015-11-14  6:01   ` [PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others Bamvor Jian Zhang
@ 2015-11-14  6:01   ` Bamvor Jian Zhang
       [not found]     ` <1447480914-14834-3-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  2015-11-14  6:01   ` [PATCH 3/3] selftest/ipc: " Bamvor Jian Zhang
  2 siblings, 1 reply; 10+ messages in thread
From: Bamvor Jian Zhang @ 2015-11-14  6:01 UTC (permalink / raw
  To: linux-api-u79uwXL29TY76Z2rM5mHXA
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, khilman-QSEj5FYQhm4dnm+yROfE0A,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A,
	broonie-DgEjT+Ai2ygdnm+yROfE0A, Bamvor Jian Zhang

The capatabilities exist in selftest but no in the TARGET list.
Add it to the TARGET.

Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 tools/testing/selftests/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 2458288..71b147e 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -1,4 +1,5 @@
 TARGETS = breakpoints
+TARGETS += capabilities
 TARGETS += cpu-hotplug
 TARGETS += efivarfs
 TARGETS += exec
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] selftest/ipc: actually test it
       [not found] ` <1447480914-14834-1-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  2015-11-14  6:01   ` [PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others Bamvor Jian Zhang
  2015-11-14  6:01   ` [PATCH 2/3] selftests/capabilities: actually test it Bamvor Jian Zhang
@ 2015-11-14  6:01   ` Bamvor Jian Zhang
  2 siblings, 0 replies; 10+ messages in thread
From: Bamvor Jian Zhang @ 2015-11-14  6:01 UTC (permalink / raw
  To: linux-api-u79uwXL29TY76Z2rM5mHXA
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, khilman-QSEj5FYQhm4dnm+yROfE0A,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A,
	broonie-DgEjT+Ai2ygdnm+yROfE0A, Bamvor Jian Zhang

The ipc testcase exist in selftest but no in the TARGET list.
Add it to the TARGET.

Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 tools/testing/selftests/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 71b147e..26dff5f 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -6,6 +6,7 @@ TARGETS += exec
 TARGETS += firmware
 TARGETS += ftrace
 TARGETS += futex
+TARGETS += ipc
 TARGETS += kcmp
 TARGETS += membarrier
 TARGETS += memfd
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others
       [not found]     ` <1447480914-14834-2-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2015-11-16  5:16       ` Michael Ellerman
       [not found]         ` <1447650976.959.5.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Ellerman @ 2015-11-16  5:16 UTC (permalink / raw
  To: Bamvor Jian Zhang, linux-api-u79uwXL29TY76Z2rM5mHXA
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, khilman-QSEj5FYQhm4dnm+yROfE0A,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A,
	broonie-DgEjT+Ai2ygdnm+yROfE0A

On Sat, 2015-11-14 at 14:01 +0800, Bamvor Jian Zhang wrote:

> User need to provide cap-ng.h and libcap-ng.so for cross compiling
> which could be done by pass extra cflags to EXTRA_CLAGS. But other
> testcases pass CFLAGS instead.
> 
> Change CLAGS ':=' to CLAGS '+=' to align with others. Delete useless
> EXTRA_CLAGS at the same time.

Actually I think you can clean this up even more. I don't see any reason it
can't use the implicit rule for compilation.

Also libraries should be in LDLIBS, not CFLAGS. And we can change the ordering
so that we don't need to define all multiple times.

Can you test this works for you?

cheers

diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile
index 8c8f0c1f0889..5f690c1ae894 100644
--- a/tools/testing/selftests/capabilities/Makefile
+++ b/tools/testing/selftests/capabilities/Makefile
@@ -1,18 +1,14 @@
-all:
-
-include ../lib.mk
-
-.PHONY: all clean
-
 TARGETS := validate_cap test_execve
 TEST_PROGS := test_execve
 
-CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
+CFLAGS += -O2 -g -std=gnu99 -Wall
+LDLIBS += -lcap-ng -lrt -ldl
 
 all: $(TARGETS)
 
+include ../lib.mk
+
 clean:
 	$(RM) $(TARGETS)
 
-$(TARGETS): %: %.c
-	$(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
+.PHONY: all clean

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/3] selftests/capabilities: actually test it
       [not found]     ` <1447480914-14834-3-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2015-11-16  5:18       ` Michael Ellerman
       [not found]         ` <1447651093.959.7.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Ellerman @ 2015-11-16  5:18 UTC (permalink / raw
  To: Bamvor Jian Zhang, linux-api-u79uwXL29TY76Z2rM5mHXA
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, khilman-QSEj5FYQhm4dnm+yROfE0A,
	tyler.baker-QSEj5FYQhm4dnm+yROfE0A,
	broonie-DgEjT+Ai2ygdnm+yROfE0A

On Sat, 2015-11-14 at 14:01 +0800, Bamvor Jian Zhang wrote:

> The capatabilities exist in selftest but no in the TARGET list.
> Add it to the TARGET.
> 
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  tools/testing/selftests/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 2458288..71b147e 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -1,4 +1,5 @@
>  TARGETS = breakpoints
> +TARGETS += capabilities
>  TARGETS += cpu-hotplug
>  TARGETS += efivarfs
>  TARGETS += exec


This breaks when you use TARGETS on the command line, eg:

 $ make -C tools/testing/selftests TARGETS=capabilities
 make[1]: *** No rule to make target 'capabilities', needed by 'all'.  Stop.

That's because the capabilities/Makefile uses the variable TARGETS internally.
You need to change the name of that variable in capabilities/Makefile, eg. to
BINARIES or something.

cheers

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others
       [not found]         ` <1447650976.959.5.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
@ 2015-11-16  8:52           ` Bamvor Zhang Jian
       [not found]             ` <CAFy1USTzsUcmwoS3Y4LRQjQykK2CSMKZ7JEDX517x6R3u801cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Bamvor Zhang Jian @ 2015-11-16  8:52 UTC (permalink / raw
  To: Michael Ellerman, linux-api
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, Kevin Hilman, Tyler Baker,
	Mark Brown

Hi, Michael

On 11/16/2015 01:16 PM, Michael Ellerman wrote:
> On Sat, 2015-11-14 at 14:01 +0800, Bamvor Jian Zhang wrote:
>
>> User need to provide cap-ng.h and libcap-ng.so for cross compiling
>> which could be done by pass extra cflags to EXTRA_CLAGS. But other
>> testcases pass CFLAGS instead.
>>
>> Change CLAGS ':=' to CLAGS '+=' to align with others. Delete useless
>> EXTRA_CLAGS at the same time.
>
> Actually I think you can clean this up even more. I don't see any reason it
> can't use the implicit rule for compilation.
>
> Also libraries should be in LDLIBS, not CFLAGS. And we can change the ordering
> so that we don't need to define all multiple times.
>
> Can you test this works for you?
>
> cheers
>
> diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile
> index 8c8f0c1f0889..5f690c1ae894 100644
> --- a/tools/testing/selftests/capabilities/Makefile
> +++ b/tools/testing/selftests/capabilities/Makefile
> @@ -1,18 +1,14 @@
> -all:
> -
> -include ../lib.mk
> -
> -.PHONY: all clean
> -
>  TARGETS := validate_cap test_execve
>  TEST_PROGS := test_execve
>
> -CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
> +CFLAGS += -O2 -g -std=gnu99 -Wall
> +LDLIBS += -lcap-ng -lrt -ldl
>
>  all: $(TARGETS)
>
> +include ../lib.mk
> +
>  clean:
>   $(RM) $(TARGETS)
>
> -$(TARGETS): %: %.c
> - $(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
> +.PHONY: all clean
>
Yes, and with your comment in 2/3, how about this one:
diff --git a/tools/testing/selftests/capabilities/Makefile
b/tools/testing/selftests/capabilities/Makefile
index 8c8f0c1..de07767 100644
--- a/tools/testing/selftests/capabilities/Makefile
+++ b/tools/testing/selftests/capabilities/Makefile
@@ -1,18 +1,13 @@
-all:
-
-include ../lib.mk
-
-.PHONY: all clean
-
-TARGETS := validate_cap test_execve
+TEST_FILES := validate_cap
 TEST_PROGS := test_execve

-CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
+CFLAGS += -O2 -g -std=gnu99 -Wall
+LDLIBS += -lcap-ng -lrt -ldl

-all: $(TARGETS)
+all: ${TEST_PROGS} ${TEST_FILES}

 clean:
- $(RM) $(TARGETS)
+ ${RM} ${TEST_PROGS} ${TEST_FILES}
+
+include ../lib.mk

-$(TARGETS): %: %.c
- $(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others
       [not found]             ` <CAFy1USTzsUcmwoS3Y4LRQjQykK2CSMKZ7JEDX517x6R3u801cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2015-11-16  9:00               ` Michael Ellerman
  0 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2015-11-16  9:00 UTC (permalink / raw
  To: Bamvor Zhang Jian, linux-api
  Cc: shuahkh-JPH+aEBZ4P+UEJcrhfAQsw, Kevin Hilman, Tyler Baker,
	Mark Brown

On Mon, 2015-11-16 at 16:52 +0800, Bamvor Zhang Jian wrote:
> Hi, Michael
> On 11/16/2015 01:16 PM, Michael Ellerman wrote:
> > On Sat, 2015-11-14 at 14:01 +0800, Bamvor Jian Zhang wrote:
> > > User need to provide cap-ng.h and libcap-ng.so for cross compiling
> > > which could be done by pass extra cflags to EXTRA_CLAGS. But other
> > > testcases pass CFLAGS instead.
> > > 
> > > Change CLAGS ':=' to CLAGS '+=' to align with others. Delete useless
> > > EXTRA_CLAGS at the same time.
> > 
> > Actually I think you can clean this up even more. I don't see any reason it
> > can't use the implicit rule for compilation.

> Yes, and with your comment in 2/3, how about this one:

Yeah that's fine. You have to say ${TEST_FILES} ${TEST_PROGS} twice, but that's
not so bad.

I think it's more common to use $( ) brackets in Makefiles, so I'd prefer you
used that rather than ${ }.

cheers

> diff --git a/tools/testing/selftests/capabilities/Makefile
> b/tools/testing/selftests/capabilities/Makefile
> index 8c8f0c1..de07767 100644
> --- a/tools/testing/selftests/capabilities/Makefile
> +++ b/tools/testing/selftests/capabilities/Makefile
> @@ -1,18 +1,13 @@
> -all:
> -
> -include ../lib.mk
> -
> -.PHONY: all clean
> -
> -TARGETS := validate_cap test_execve
> +TEST_FILES := validate_cap
>  TEST_PROGS := test_execve
> 
> -CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng
> +CFLAGS += -O2 -g -std=gnu99 -Wall
> +LDLIBS += -lcap-ng -lrt -ldl
> 
> -all: $(TARGETS)
> +all: ${TEST_PROGS} ${TEST_FILES}
> 
>  clean:
> - $(RM) $(TARGETS)
> + ${RM} ${TEST_PROGS} ${TEST_FILES}
> +
> +include ../lib.mk
> 
> -$(TARGETS): %: %.c
> - $(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl
> --
> To unsubscribe from this list: send the line "unsubscribe linux-api" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/3] selftests/capabilities: actually test it
       [not found]         ` <1447651093.959.7.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
@ 2015-11-16 18:49           ` Andy Lutomirski
       [not found]             ` <CALCETrWOP=4pJrnJsfW2zVWvGHNnZDC5HYy5tOop8W-X4U2H8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Andy Lutomirski @ 2015-11-16 18:49 UTC (permalink / raw
  To: Michael Ellerman
  Cc: Bamvor Jian Zhang, Linux API, Shuah Khan, Kevin Hilman,
	Tyler Baker, Mark Brown

On Sun, Nov 15, 2015 at 9:18 PM, Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org> wrote:
> On Sat, 2015-11-14 at 14:01 +0800, Bamvor Jian Zhang wrote:
>
>> The capatabilities exist in selftest but no in the TARGET list.
>> Add it to the TARGET.
>>
>> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>  tools/testing/selftests/Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index 2458288..71b147e 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -1,4 +1,5 @@
>>  TARGETS = breakpoints
>> +TARGETS += capabilities
>>  TARGETS += cpu-hotplug
>>  TARGETS += efivarfs
>>  TARGETS += exec
>
>
> This breaks when you use TARGETS on the command line, eg:

Taking a step back for a second: isn't the variable you want
TEST_PROGS, not TARGETS?

--Andy

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/3] selftests/capabilities: actually test it
       [not found]             ` <CALCETrWOP=4pJrnJsfW2zVWvGHNnZDC5HYy5tOop8W-X4U2H8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2015-11-16 18:56               ` Andy Lutomirski
  0 siblings, 0 replies; 10+ messages in thread
From: Andy Lutomirski @ 2015-11-16 18:56 UTC (permalink / raw
  To: Michael Ellerman
  Cc: Bamvor Jian Zhang, Linux API, Shuah Khan, Kevin Hilman,
	Tyler Baker, Mark Brown

On Mon, Nov 16, 2015 at 10:49 AM, Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org> wrote:
> On Sun, Nov 15, 2015 at 9:18 PM, Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org> wrote:
>> On Sat, 2015-11-14 at 14:01 +0800, Bamvor Jian Zhang wrote:
>>
>>> The capatabilities exist in selftest but no in the TARGET list.
>>> Add it to the TARGET.
>>>
>>> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>> ---
>>>  tools/testing/selftests/Makefile | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>>> index 2458288..71b147e 100644
>>> --- a/tools/testing/selftests/Makefile
>>> +++ b/tools/testing/selftests/Makefile
>>> @@ -1,4 +1,5 @@
>>>  TARGETS = breakpoints
>>> +TARGETS += capabilities
>>>  TARGETS += cpu-hotplug
>>>  TARGETS += efivarfs
>>>  TARGETS += exec
>>
>>
>> This breaks when you use TARGETS on the command line, eg:
>
> Taking a step back for a second: isn't the variable you want
> TEST_PROGS, not TARGETS?

Never mind, I read the patch wrong.

--Andy

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2015-11-16 18:56 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-14  6:01 [PATCH 0/3] Enable two testcases in kselftest Bamvor Jian Zhang
     [not found] ` <1447480914-14834-1-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-11-14  6:01   ` [PATCH 1/3] selftests/capabilities: align the usage of CFLAGS with others Bamvor Jian Zhang
     [not found]     ` <1447480914-14834-2-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-11-16  5:16       ` Michael Ellerman
     [not found]         ` <1447650976.959.5.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-11-16  8:52           ` Bamvor Zhang Jian
     [not found]             ` <CAFy1USTzsUcmwoS3Y4LRQjQykK2CSMKZ7JEDX517x6R3u801cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-16  9:00               ` Michael Ellerman
2015-11-14  6:01   ` [PATCH 2/3] selftests/capabilities: actually test it Bamvor Jian Zhang
     [not found]     ` <1447480914-14834-3-git-send-email-bamvor.zhangjian-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-11-16  5:18       ` Michael Ellerman
     [not found]         ` <1447651093.959.7.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-11-16 18:49           ` Andy Lutomirski
     [not found]             ` <CALCETrWOP=4pJrnJsfW2zVWvGHNnZDC5HYy5tOop8W-X4U2H8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-16 18:56               ` Andy Lutomirski
2015-11-14  6:01   ` [PATCH 3/3] selftest/ipc: " Bamvor Jian Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).