* [PATCH] selftests/kdbus: handle cap_get_proc() error properly
@ 2015-06-17 14:18 Sergei Zviagintsev
[not found] ` <1434550697-24785-1-git-send-email-sergei-E844GTqJAzo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Zviagintsev @ 2015-06-17 14:18 UTC (permalink / raw
To: Greg Kroah-Hartman, Daniel Mack, David Herrmann, Djalal Harouni
Cc: Shuah Khan, linux-kernel, linux-api, Sergei Zviagintsev
Fix typo in checking error value of cap_get_proc(): cap -> caps
Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
---
tools/testing/selftests/kdbus/kdbus-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/kdbus/kdbus-util.c b/tools/testing/selftests/kdbus/kdbus-util.c
index 1e267d585a14..a3e49b04f3a7 100644
--- a/tools/testing/selftests/kdbus/kdbus-util.c
+++ b/tools/testing/selftests/kdbus/kdbus-util.c
@@ -1547,7 +1547,7 @@ int test_is_capable(int cap, ...)
cap_t caps;
caps = cap_get_proc();
- if (!cap) {
+ if (!caps) {
ret = -errno;
kdbus_printf("error cap_get_proc(): %d (%m)\n", ret);
return ret;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/kdbus: handle cap_get_proc() error properly
[not found] ` <1434550697-24785-1-git-send-email-sergei-E844GTqJAzo@public.gmane.org>
@ 2015-06-17 14:37 ` Greg Kroah-Hartman
[not found] ` <20150617143720.GA19114-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2015-06-17 14:37 UTC (permalink / raw
To: Sergei Zviagintsev
Cc: Daniel Mack, David Herrmann, Djalal Harouni, Shuah Khan,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-api-u79uwXL29TY76Z2rM5mHXA
On Wed, Jun 17, 2015 at 05:18:13PM +0300, Sergei Zviagintsev wrote:
> Fix typo in checking error value of cap_get_proc(): cap -> caps
>
> Signed-off-by: Sergei Zviagintsev <sergei-E844GTqJAzo@public.gmane.org>
> ---
> tools/testing/selftests/kdbus/kdbus-util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent 5 patches, yet no hints as to what order they should be applied
in :(
Please resend in a patch series that is properly threaded so we can
handle this correctly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/kdbus: handle cap_get_proc() error properly
[not found] ` <20150617143720.GA19114-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
@ 2015-06-17 16:46 ` Sergei Zviagintsev
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Zviagintsev @ 2015-06-17 16:46 UTC (permalink / raw
To: Greg Kroah-Hartman
Cc: Daniel Mack, David Herrmann, Djalal Harouni, Shuah Khan,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-api-u79uwXL29TY76Z2rM5mHXA
Hi Greg,
On Wed, Jun 17, 2015 at 07:37:20AM -0700, Greg Kroah-Hartman wrote:
> You sent 5 patches, yet no hints as to what order they should be applied
> in :(
>
> Please resend in a patch series that is properly threaded so we can
> handle this correctly.
Thank you for feedback! I've resent series threaded:
http://lkml.kernel.org/g/1434558808-16129-1-git-send-email-sergei-E844GTqJAzo@public.gmane.org
It was unclear for me whether to use threaded layout and whether not,
but now it seems that I got it. Though those applied fine in any order
and had no chances to piss of a kernel maintainer :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-17 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-17 14:18 [PATCH] selftests/kdbus: handle cap_get_proc() error properly Sergei Zviagintsev
[not found] ` <1434550697-24785-1-git-send-email-sergei-E844GTqJAzo@public.gmane.org>
2015-06-17 14:37 ` Greg Kroah-Hartman
[not found] ` <20150617143720.GA19114-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-06-17 16:46 ` Sergei Zviagintsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).