From: "Dmitry V. Levin" <ldv@strace.io>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: dave.hansen@linux.intel.com, bp@alien8.de, x86@kernel.org,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/uapi: fix SHADOW_STACK_SET_TOKEN type
Date: Mon, 23 Oct 2023 23:11:18 +0300 [thread overview]
Message-ID: <20231023201118.GA19800@altlinux.org> (raw)
In-Reply-To: <006699efc5ccdce1bd62f45ef2852ab0233e295c.camel@intel.com>
On Mon, Oct 23, 2023 at 04:36:48PM +0000, Edgecombe, Rick P wrote:
> On Mon, 2023-10-23 at 01:21 +0300, Dmitry V. Levin wrote:
> > Fix the type of SHADOW_STACK_SET_TOKEN to match the type of the
> > corresponding "flags" argument of map_shadow_stack syscall which
> > is of type "unsigned int".
> >
> > Fixes: c35559f94ebc3 ("x86/shstk: Introduce map_shadow_stack
> > syscall")
> > Signed-off-by: Dmitry V. Levin <ldv@strace.io>
> > ---
> > arch/x86/include/uapi/asm/mman.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/uapi/asm/mman.h
> > b/arch/x86/include/uapi/asm/mman.h
> > index 46cdc941f958..8419e25bb617 100644
> > --- a/arch/x86/include/uapi/asm/mman.h
> > +++ b/arch/x86/include/uapi/asm/mman.h
> > @@ -6,7 +6,7 @@
> > #define MAP_ABOVE4G 0x80 /* only map above 4GB */
> >
> > /* Flags for map_shadow_stack(2) */
> > -#define SHADOW_STACK_SET_TOKEN (1ULL << 0) /* Set up a restore
> > token in the shadow stack */
> > +#define SHADOW_STACK_SET_TOKEN (1U << 0) /* Set up a restore
> > token in the shadow stack */
> >
> > #include <asm-generic/mman.h>
>
> Good point that they are mismatched. I don't remember why flags is not
> an unsigned long though. I wonder if we should quick change it to an
> unsigned long, if it's not too late. We probably won't run out of
> flags, but maybe some value could get stuffed in the upper bits or
> something someday.
We usually don't use unsigned long for flags because we support 32-bit
architectures.
--
ldv
prev parent reply other threads:[~2023-10-23 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 22:21 [PATCH] x86/uapi: fix SHADOW_STACK_SET_TOKEN type Dmitry V. Levin
2023-10-23 16:36 ` Edgecombe, Rick P
2023-10-23 20:11 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023201118.GA19800@altlinux.org \
--to=ldv@strace.io \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).