From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Tycho Andersen <tycho@tycho.pizza>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pidfd: change pidfd_send_signal() to respect PIDFD_THREAD
Date: Fri, 9 Feb 2024 11:28:17 +0100 [thread overview]
Message-ID: <20240209102816.GA3282@redhat.com> (raw)
In-Reply-To: <20240208143407.GF19801@redhat.com>
On 02/08, Oleg Nesterov wrote:
>
> Is prepare_kill_siginfo() correct when we send a signal to the child
> pid namespace? si_pid = task_tgid_vnr(current) doesn't look right
Yes, but iiuc send_signal_locked() should fixup si_pid/si_uid, so it
is not buggy.
> And why do we need it at all? Can't sys_kill() and pidfd_send_signal()
> just use SEND_SIG_NOINFO?
Probably yes. And even do_tkill() can use SEND_SIG_NOINFO if we change
__send_signal_locked() to check the type before ".si_code = SI_USER".
but then TP_STORE_SIGINFO() needs some changes...
I'll try to do this later, I do not want to mix this change with the
PIDFD_THREAD changes.
Oleg.
next prev parent reply other threads:[~2024-02-09 10:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 11:45 [PATCH] pidfd: change pidfd_send_signal() to respect PIDFD_THREAD Oleg Nesterov
2024-02-08 13:15 ` Christian Brauner
2024-02-08 13:53 ` Oleg Nesterov
2024-02-08 14:31 ` Christian Brauner
2024-02-08 14:34 ` Oleg Nesterov
2024-02-08 15:33 ` Christian Brauner
2024-02-08 16:11 ` Oleg Nesterov
2024-02-09 10:28 ` Oleg Nesterov [this message]
2024-02-09 11:29 ` Christian Brauner
2024-02-08 14:06 ` Oleg Nesterov
2024-02-08 14:33 ` Christian Brauner
2024-02-08 15:33 ` Eric W. Biederman
2024-02-08 15:57 ` Oleg Nesterov
2024-02-09 9:26 ` Christian Brauner
2024-02-09 10:53 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209102816.GA3282@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).