From: Michael Ellerman <mpe@ellerman.id.au>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Cc: "svens@linux.ibm.com" <svens@linux.ibm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"schwab@linux-m68k.org" <schwab@linux-m68k.org>,
"brgerst@gmail.com" <brgerst@gmail.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"monstr@monstr.eu" <monstr@monstr.eu>,
"borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"dalias@libc.org" <dalias@libc.org>,
"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hca@linux.ibm.com" <hca@linux.ibm.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"Lutomirski, Andy" <luto@kernel.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
"tsbogend@alpha.franken.de" <tsbogend@alpha.franken.de>,
"broonie@kernel.org" <broonie@kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"acme@kernel.org" <acme@kernel.org>,
"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
"deller@gmx.de" <deller@gmx.de>,
"debug@rivosinc.com" <debug@rivosinc.com>,
"rmclure@linux.ibm.com" <rmclure@linux.ibm.com>,
"gor@linux.ibm.com" <gor@linux.ibm.com>,
"slyich@gmail.com" <slyich@gmail.com>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
"chris@zankel.net" <chris@zankel.net>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
"mattst88@gmail.com" <mattst88@gmail.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
"bp@alien8.de" <bp@alien8.de>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"irogers@google.com" <irogers@google.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"will@kernel.org" <will@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH 2/2] arch: Reserve map_shadow_stack() syscall number for all architectures
Date: Thu, 14 Sep 2023 22:26:47 +1000 [thread overview]
Message-ID: <871qf17xfc.fsf@mail.lhotse> (raw)
In-Reply-To: <8b7106881fa227a64b4e951c6b9240a7126ac4a2.camel@intel.com>
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com> writes:
> On Mon, 2023-09-11 at 18:02 +0000, Sohil Mehta wrote:
>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl
>> b/arch/powerpc/kernel/syscalls/syscall.tbl
>> index 20e50586e8a2..2767b8a42636 100644
>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl
>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl
>> @@ -539,3 +539,4 @@
>> 450 nospu set_mempolicy_home_node sys_set_mempolicy_hom
>> e_node
>> 451 common cachestat sys_cachestat
>> 452 common fchmodat2 sys_fchmodat2
>> +453 common map_shadow_stack sys_map_shadow_stack
>
> I noticed in powerpc, the not implemented syscalls are manually mapped
> to sys_ni_syscall. It also has some special extra sys_ni_syscall()
> implementation bits to handle both ARCH_HAS_SYSCALL_WRAPPER and
> !ARCH_HAS_SYSCALL_WRAPPER. So wondering if it might need special
> treatment. Did you see those parts?
I don't think it needs any special treatment. It's processed by the same
script as other arches (scripts/syscalltbl.sh). So if there's no compat
or native entry it will default to sys_ni_syscall.
I think it's just habit/historical that we always spell out sys_ni_syscall.
cheers
next prev parent reply other threads:[~2023-09-14 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 18:02 [PATCH 0/2] arch: Sync all syscall tables with 2 newly added system calls Sohil Mehta
2023-09-11 18:02 ` [PATCH 1/2] tools headers UAPI: Sync fchmodat2() syscall table entries Sohil Mehta
2023-09-11 18:02 ` [PATCH 2/2] arch: Reserve map_shadow_stack() syscall number for all architectures Sohil Mehta
2023-09-11 21:10 ` Edgecombe, Rick P
2023-09-13 19:18 ` Sohil Mehta
2023-09-13 22:05 ` Edgecombe, Rick P
2023-09-14 12:26 ` Michael Ellerman [this message]
2023-09-13 19:32 ` [PATCH 0/2] arch: Sync all syscall tables with 2 newly added system calls Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qf17xfc.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=James.Bottomley@HansenPartnership.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=christophe.leroy@csgroup.eu \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=debug@rivosinc.com \
--cc=deller@gmx.de \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=irogers@google.com \
--cc=jcmvbkbc@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas.bulwahn@gmail.com \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=namhyung@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rmclure@linux.ibm.com \
--cc=schwab@linux-m68k.org \
--cc=slyich@gmail.com \
--cc=sohil.mehta@intel.com \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).