From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Gregory Price <gourry.memverge@gmail.com>,
linux-mm@kvack.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
tglx@linutronix.de, luto@kernel.org, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
mhocko@kernel.org, tj@kernel.org, ying.huang@intel.com,
gregory.price@memverge.com, corbet@lwn.net, rakie.kim@sk.com,
hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
peterz@infradead.org, jgroves@micron.com,
ravis.opensrc@micron.com, sthanneeru@micron.com,
emirakhur@micron.com, Hasan.Maruf@amd.com,
seungjun.ha@samsung.com
Subject: Re: [PATCH v4 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave
Date: Wed, 3 Jan 2024 14:16:20 +0300 [thread overview]
Message-ID: <94405fba-8539-425b-b21a-3016cdd7be91@moroto.mountain> (raw)
In-Reply-To: <20231218194631.21667-12-gregory.price@memverge.com>
Hi Gregory,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gregory-Price/mm-mempolicy-implement-the-sysfs-based-weighted_interleave-interface/20231219-074837
base: https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git perf-tools
patch link: https://lore.kernel.org/r/20231218194631.21667-12-gregory.price%40memverge.com
patch subject: [PATCH v4 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave
config: x86_64-randconfig-161-20231219 (https://download.01.org/0day-ci/archive/20231220/202312200223.7X9rUFgu-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202312200223.7X9rUFgu-lkp@intel.com/
smatch warnings:
mm/mempolicy.c:2044 __do_sys_get_mempolicy2() warn: maybe return -EFAULT instead of the bytes remaining?
mm/mempolicy.c:2044 __do_sys_get_mempolicy2() warn: maybe return -EFAULT instead of the bytes remaining?
vim +2044 mm/mempolicy.c
a2af87404eb73e Gregory Price 2023-12-18 1992 SYSCALL_DEFINE4(get_mempolicy2, struct mpol_args __user *, uargs, size_t, usize,
a2af87404eb73e Gregory Price 2023-12-18 1993 unsigned long, addr, unsigned long, flags)
a2af87404eb73e Gregory Price 2023-12-18 1994 {
a2af87404eb73e Gregory Price 2023-12-18 1995 struct mpol_args kargs;
a2af87404eb73e Gregory Price 2023-12-18 1996 struct mempolicy_args margs;
a2af87404eb73e Gregory Price 2023-12-18 1997 int err;
a2af87404eb73e Gregory Price 2023-12-18 1998 nodemask_t policy_nodemask;
a2af87404eb73e Gregory Price 2023-12-18 1999 unsigned long __user *nodes_ptr;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2000 unsigned char __user *weights_ptr;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2001 unsigned char weights[MAX_NUMNODES];
a2af87404eb73e Gregory Price 2023-12-18 2002
a2af87404eb73e Gregory Price 2023-12-18 2003 if (flags & ~(MPOL_F_ADDR))
a2af87404eb73e Gregory Price 2023-12-18 2004 return -EINVAL;
a2af87404eb73e Gregory Price 2023-12-18 2005
a2af87404eb73e Gregory Price 2023-12-18 2006 /* initialize any memory liable to be copied to userland */
a2af87404eb73e Gregory Price 2023-12-18 2007 memset(&margs, 0, sizeof(margs));
8bfd7ddc0dd439 Gregory Price 2023-12-18 2008 memset(weights, 0, sizeof(weights));
a2af87404eb73e Gregory Price 2023-12-18 2009
a2af87404eb73e Gregory Price 2023-12-18 2010 err = copy_struct_from_user(&kargs, sizeof(kargs), uargs, usize);
a2af87404eb73e Gregory Price 2023-12-18 2011 if (err)
a2af87404eb73e Gregory Price 2023-12-18 2012 return -EINVAL;
a2af87404eb73e Gregory Price 2023-12-18 2013
8bfd7ddc0dd439 Gregory Price 2023-12-18 2014 if (kargs.il_weights)
8bfd7ddc0dd439 Gregory Price 2023-12-18 2015 margs.il_weights = weights;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2016 else
8bfd7ddc0dd439 Gregory Price 2023-12-18 2017 margs.il_weights = NULL;
8bfd7ddc0dd439 Gregory Price 2023-12-18 2018
a2af87404eb73e Gregory Price 2023-12-18 2019 margs.policy_nodes = kargs.pol_nodes ? &policy_nodemask : NULL;
a2af87404eb73e Gregory Price 2023-12-18 2020 if (flags & MPOL_F_ADDR)
a2af87404eb73e Gregory Price 2023-12-18 2021 err = do_get_vma_mempolicy(untagged_addr(addr), NULL, &margs);
a2af87404eb73e Gregory Price 2023-12-18 2022 else
a2af87404eb73e Gregory Price 2023-12-18 2023 err = do_get_task_mempolicy(&margs);
a2af87404eb73e Gregory Price 2023-12-18 2024
a2af87404eb73e Gregory Price 2023-12-18 2025 if (err)
a2af87404eb73e Gregory Price 2023-12-18 2026 return err;
a2af87404eb73e Gregory Price 2023-12-18 2027
a2af87404eb73e Gregory Price 2023-12-18 2028 kargs.mode = margs.mode;
a2af87404eb73e Gregory Price 2023-12-18 2029 kargs.mode_flags = margs.mode_flags;
a2af87404eb73e Gregory Price 2023-12-18 2030 kargs.policy_node = margs.policy_node;
a2af87404eb73e Gregory Price 2023-12-18 2031 kargs.home_node = margs.home_node;
a2af87404eb73e Gregory Price 2023-12-18 2032 if (kargs.pol_nodes) {
a2af87404eb73e Gregory Price 2023-12-18 2033 nodes_ptr = u64_to_user_ptr(kargs.pol_nodes);
a2af87404eb73e Gregory Price 2023-12-18 2034 err = copy_nodes_to_user(nodes_ptr, kargs.pol_maxnodes,
a2af87404eb73e Gregory Price 2023-12-18 2035 margs.policy_nodes);
a2af87404eb73e Gregory Price 2023-12-18 2036 if (err)
a2af87404eb73e Gregory Price 2023-12-18 2037 return err;
This looks wrong as well.
a2af87404eb73e Gregory Price 2023-12-18 2038 }
a2af87404eb73e Gregory Price 2023-12-18 2039
8bfd7ddc0dd439 Gregory Price 2023-12-18 2040 if (kargs.mode == MPOL_WEIGHTED_INTERLEAVE && kargs.il_weights) {
8bfd7ddc0dd439 Gregory Price 2023-12-18 2041 weights_ptr = u64_to_user_ptr(kargs.il_weights);
8bfd7ddc0dd439 Gregory Price 2023-12-18 2042 err = copy_to_user(weights_ptr, weights, kargs.pol_maxnodes);
8bfd7ddc0dd439 Gregory Price 2023-12-18 2043 if (err)
8bfd7ddc0dd439 Gregory Price 2023-12-18 @2044 return err;
This should return -EFAULT same as the copy_to_user() on the next line.
8bfd7ddc0dd439 Gregory Price 2023-12-18 2045 }
8bfd7ddc0dd439 Gregory Price 2023-12-18 2046
a2af87404eb73e Gregory Price 2023-12-18 2047 return copy_to_user(uargs, &kargs, usize) ? -EFAULT : 0;
a2af87404eb73e Gregory Price 2023-12-18 2048 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-01-03 11:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 19:46 [PATCH v4 00/11] mempolicy2, mbind2, and weighted interleave Gregory Price
2023-12-18 19:46 ` [PATCH v4 01/11] mm/mempolicy: implement the sysfs-based weighted_interleave interface Gregory Price
2023-12-18 19:46 ` [PATCH v4 02/11] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving Gregory Price
2023-12-18 19:46 ` [PATCH v4 03/11] mm/mempolicy: refactor sanitize_mpol_flags for reuse Gregory Price
2023-12-18 19:46 ` [PATCH v4 04/11] mm/mempolicy: create struct mempolicy_args for creating new mempolicies Gregory Price
2023-12-18 19:46 ` [PATCH v4 05/11] mm/mempolicy: refactor kernel_get_mempolicy for code re-use Gregory Price
2023-12-18 19:46 ` [PATCH v4 06/11] mm/mempolicy: allow home_node to be set by mpol_new Gregory Price
2023-12-18 19:46 ` [PATCH v4 07/11] mm/mempolicy: add userland mempolicy arg structure Gregory Price
2023-12-18 19:46 ` [PATCH v4 08/11] mm/mempolicy: add set_mempolicy2 syscall Gregory Price
2023-12-18 19:46 ` [PATCH v4 09/11] mm/mempolicy: add get_mempolicy2 syscall Gregory Price
2023-12-18 19:46 ` [PATCH v4 10/11] mm/mempolicy: add the mbind2 syscall Gregory Price
2023-12-19 12:24 ` kernel test robot
2023-12-20 0:48 ` kernel test robot
2023-12-18 19:46 ` [PATCH v4 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave Gregory Price
2023-12-19 3:07 ` Huang, Ying
2023-12-19 18:12 ` Gregory Price
2024-01-03 11:16 ` Dan Carpenter [this message]
2023-12-19 3:04 ` [PATCH v4 00/11] mempolicy2, mbind2, and " Huang, Ying
2023-12-19 18:09 ` Gregory Price
2023-12-20 2:27 ` Huang, Ying
2023-12-26 7:26 ` Gregory Price
2024-01-02 4:08 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94405fba-8539-425b-b21a-3016cdd7be91@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=Hasan.Maruf@amd.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=emirakhur@micron.com \
--cc=gourry.memverge@gmail.com \
--cc=gregory.price@memverge.com \
--cc=honggyu.kim@sk.com \
--cc=hpa@zytor.com \
--cc=hyeongtak.ji@sk.com \
--cc=jgroves@micron.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rakie.kim@sk.com \
--cc=ravis.opensrc@micron.com \
--cc=seungjun.ha@samsung.com \
--cc=sthanneeru@micron.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vtavarespetr@micron.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).