From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: linux-security-module@vger.kernel.org, jmorris@namei.org,
serge@hallyn.com, keescook@chromium.org,
john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp,
stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, mic@digikod.net
Subject: Re: [PATCH v12 7/11] LSM: Helpers for attribute names and filling lsm_ctx
Date: Fri, 30 Jun 2023 14:23:43 -0400 [thread overview]
Message-ID: <CAHC9VhQfejt=5+pUbUGZr1XAAEQsdmGBsenTiP-na6wmUUVUVg@mail.gmail.com> (raw)
In-Reply-To: <d39d5784-058f-9298-1cdb-2f0e550b206a@schaufler-ca.com>
On Fri, Jun 30, 2023 at 1:11 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> On 6/29/2023 7:14 PM, Paul Moore wrote:
> > On Jun 29, 2023 Casey Schaufler <casey@schaufler-ca.com> wrote:
> >> Add lsm_name_to_attr(), which translates a text string to a
> >> LSM_ATTR value if one is available.
> >>
> >> Add lsm_fill_user_ctx(), which fills a struct lsm_ctx, including
> >> the trailing attribute value.
> >>
> >> All are used in module specific components of LSM system calls.
> >>
> >> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> >> Reviewed-by: Serge Hallyn <serge@hallyn.com>
> >> ---
> >> include/linux/security.h | 14 +++++++++++++
> >> security/lsm_syscalls.c | 24 ++++++++++++++++++++++
> >> security/security.c | 44 ++++++++++++++++++++++++++++++++++++++++
> >> 3 files changed, 82 insertions(+)
> > ..
> >
> >> diff --git a/security/security.c b/security/security.c
> >> index 199db23581f1..72ad7197b2c9 100644
> >> --- a/security/security.c
> >> +++ b/security/security.c
> >> @@ -770,6 +770,50 @@ static int lsm_superblock_alloc(struct super_block *sb)
> >> return 0;
> >> }
> >>
> >> +/**
> >> + * lsm_fill_user_ctx - Fill a user space lsm_ctx structure
> >> + * @ctx: an LSM context to be filled
> >> + * @context: the new context value
> >> + * @context_size: the size of the new context value
> >> + * @id: LSM id
> >> + * @flags: LSM defined flags
> >> + *
> >> + * Fill all of the fields in a user space lsm_ctx structure.
> >> + * Caller is assumed to have verified that @ctx has enough space
> >> + * for @context.
> >> + *
> >> + * The total length is padded to a multiple of 64 bits to
> >> + * accomodate possible alignment issues.
> > We should drop the sentence above now that alignment is the caller's
> > responsibility, but since that was largely my fault I can fix this up
> > during the merge assuming you're okay with that Casey.
>
> I have to fix the error in patch 8/11 anyway. I can fix this, too.
Great, thanks.
--
paul-moore.com
next prev parent reply other threads:[~2023-06-30 18:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230629195535.2590-1-casey.ref@schaufler-ca.com>
2023-06-29 19:55 ` [PATCH v12 00/11] LSM: Three basic syscalls Casey Schaufler
2023-06-29 19:55 ` [PATCH v12 01/11] LSM: Identify modules by more than name Casey Schaufler
2023-07-11 15:35 ` Mickaël Salaün
2023-06-29 19:55 ` [PATCH v12 02/11] LSM: Maintain a table of LSM attribute data Casey Schaufler
2023-07-11 15:35 ` Mickaël Salaün
2023-07-14 19:42 ` Casey Schaufler
2023-07-21 21:40 ` Paul Moore
2023-06-29 19:55 ` [PATCH v12 03/11] proc: Use lsmids instead of lsm names for attrs Casey Schaufler
2023-07-11 15:36 ` Mickaël Salaün
2023-06-29 19:55 ` [PATCH v12 04/11] LSM: syscalls for current process attributes Casey Schaufler
2023-07-11 15:36 ` Mickaël Salaün
2023-07-14 21:59 ` Casey Schaufler
2023-07-21 22:28 ` Paul Moore
2023-07-30 22:34 ` Casey Schaufler
2023-06-29 19:55 ` [PATCH v12 05/11] LSM: Create lsm_list_modules system call Casey Schaufler
2023-07-11 15:36 ` Mickaël Salaün
2023-07-14 22:10 ` Casey Schaufler
2023-06-29 19:55 ` [PATCH v12 06/11] LSM: wireup Linux Security Module syscalls Casey Schaufler
2023-07-11 15:37 ` Mickaël Salaün
2023-06-29 19:55 ` [PATCH v12 07/11] LSM: Helpers for attribute names and filling lsm_ctx Casey Schaufler
2023-06-30 2:14 ` [PATCH v12 7/11] " Paul Moore
2023-06-30 17:11 ` Casey Schaufler
2023-06-30 18:23 ` Paul Moore [this message]
2023-06-29 19:55 ` [PATCH v12 08/11] Smack: implement setselfattr and getselfattr hooks Casey Schaufler
2023-06-30 2:14 ` [PATCH v12 8/11] " Paul Moore
2023-06-30 17:10 ` Casey Schaufler
2023-06-29 19:55 ` [PATCH v12 09/11] AppArmor: Add selfattr hooks Casey Schaufler
2023-06-29 19:55 ` [PATCH v12 10/11] SELinux: " Casey Schaufler
2023-07-11 15:37 ` Mickaël Salaün
2023-06-29 19:55 ` [PATCH v12 11/11] LSM: selftests for Linux Security Module syscalls Casey Schaufler
2023-07-11 18:16 ` Mickaël Salaün
2023-06-30 2:14 ` [PATCH v12 0/11] LSM: Three basic syscalls Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhQfejt=5+pUbUGZr1XAAEQsdmGBsenTiP-na6wmUUVUVg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).