From: Gregory Price <gregory.price@memverge.com>
To: Gregory Price <gourry.memverge@gmail.com>,
linux-mm@kvack.org, jgroves@micron.com, ravis.opensrc@micron.com,
sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
arnd@arndb.de, tglx@linutronix.de, luto@kernel.org,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, mhocko@kernel.org, tj@kernel.org,
ying.huang@intel.com, corbet@lwn.net, rakie.kim@sk.com,
hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
peterz@infradead.org
Subject: Re: [RFC PATCH 01/11] mm/mempolicy: implement the sysfs-based weighted_interleave interface
Date: Thu, 7 Dec 2023 19:11:59 -0500 [thread overview]
Message-ID: <ZXJfT/EXFu+MtTkW@memverge.com> (raw)
In-Reply-To: <uxqkbmqbvcvx6wc3g2h6vhkutv5flrq6rslwdfs7pa6kknupwh@a245pbtfqfgj>
On Thu, Dec 07, 2023 at 01:56:07PM -0800, Davidlohr Bueso wrote:
> On Wed, 06 Dec 2023, Gregory Price wrote:
> > +
> > +What: /sys/kernel/mm/mempolicy/weighted_interleave/nodeN/
> > +Date: December 2023
> > +Contact: Linux memory management mailing list <linux-mm@kvack.org>
> > +Description: Configuration interface for accesses initiated from nodeN
> > +
> > + The directory to configure access initiator weights for nodeN.
> > +
> > + Possible numa nodes which have not been marked as a CPU node
> > + at boot will not have a nodeN directory made for them at boot.
>
> This could be better rephrased without the negation. ie:
>
> "Only numa nodes with CPUs (compute) will have a nodeN directory."
>
I thought documentation was supposed to be as confusing as possible.
lol I'll update it. reading it now, this is awful.
> > + Hotplug for CPU nodes is not supported.
>
> Can this even happen? Hot-adding a previously offlined CPU won't change/add a
> new numa node. So just rm the line altogether?
>
I... have no idea. In that sense, aye aye!
> > +static ssize_t node_weight_show(struct kobject *kobj,
> > + struct kobj_attribute *attr, char *buf)
> > +
> > +static ssize_t node_weight_store(struct kobject *kobj,
> > + struct kobj_attribute *attr,
> > + const char *buf, size_t count)
>
> iw_table will need some (basic) form of serialization.
>
originally the SKH group recommended a serialized "N*W,N*W,..." format,
but this doesn't work for a matrix.
Possibly i could add `N-M*W,...;N-M*W,...` and add a nodeN/weightlist
interface that lets you acquire the whole iw_table for one or more
nodes. Might be a nice extension.
I figured there is an aversion to multi-value sysfs files, so I reverted
back to a one-file-one-value file. If there is a preference for the
fully serialized methods, I'll happily add those. Easy enough and I
already have the code to parse it.
~Gregory
next prev parent reply other threads:[~2023-12-08 0:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 0:27 [RFC PATCH 00/11] mempolicy2, mbind2, and weighted interleave Gregory Price
2023-12-07 0:27 ` [RFC PATCH 01/11] mm/mempolicy: implement the sysfs-based weighted_interleave interface Gregory Price
2023-12-07 21:56 ` Davidlohr Bueso
2023-12-07 22:17 ` Davidlohr Bueso
2023-12-08 0:11 ` Gregory Price [this message]
2023-12-07 0:27 ` [RFC PATCH 02/11] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving Gregory Price
2023-12-07 0:27 ` [RFC PATCH 03/11] mm/mempolicy: refactor sanitize_mpol_flags for reuse Gregory Price
2023-12-07 0:27 ` [RFC PATCH 04/11] mm/mempolicy: create struct mempolicy_args for creating new mempolicies Gregory Price
2023-12-07 0:27 ` [RFC PATCH 05/11] mm/mempolicy: refactor kernel_get_mempolicy for code re-use Gregory Price
2023-12-07 0:27 ` [RFC PATCH 06/11] mm/mempolicy: allow home_node to be set by mpol_new Gregory Price
2023-12-07 0:27 ` [RFC PATCH 07/11] mm/mempolicy: add userland mempolicy arg structure Gregory Price
2023-12-07 7:13 ` Arnd Bergmann
2023-12-07 14:58 ` Gregory Price
2023-12-07 15:43 ` Arnd Bergmann
2023-12-08 0:05 ` Gregory Price
2023-12-07 0:27 ` [RFC PATCH 08/11] mm/mempolicy: add set_mempolicy2 syscall Gregory Price
2023-12-07 0:27 ` [RFC PATCH 09/11] mm/mempolicy: add get_mempolicy2 syscall Gregory Price
2023-12-07 0:27 ` [RFC PATCH 10/11] mm/mempolicy: add the mbind2 syscall Gregory Price
2023-12-07 0:27 ` [RFC PATCH 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXJfT/EXFu+MtTkW@memverge.com \
--to=gregory.price@memverge.com \
--cc=Hasan.Maruf@amd.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=emirakhur@micron.com \
--cc=gourry.memverge@gmail.com \
--cc=honggyu.kim@sk.com \
--cc=hpa@zytor.com \
--cc=hyeongtak.ji@sk.com \
--cc=jgroves@micron.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rakie.kim@sk.com \
--cc=ravis.opensrc@micron.com \
--cc=sthanneeru@micron.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vtavarespetr@micron.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).