From: Gregory Price <gregory.price@memverge.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Gregory Price <gourry.memverge@gmail.com>,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-arch@vger.kernel.org,
akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de,
luto@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org,
tj@kernel.org, ying.huang@intel.com, corbet@lwn.net,
rakie.kim@sk.com, hyeongtak.ji@sk.com, honggyu.kim@sk.com,
vtavarespetr@micron.com, peterz@infradead.org,
jgroves@micron.com, ravis.opensrc@micron.com,
sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
seungjun.ha@samsung.com, Frank van der Linden <fvdl@google.com>
Subject: Re: [PATCH v6 08/12] mm/mempolicy: add userland mempolicy arg structure
Date: Wed, 3 Jan 2024 21:03:51 -0500 [thread overview]
Message-ID: <ZZYSB3kUOjCSo28h@memverge.com> (raw)
In-Reply-To: <429dd825-204a-4b11-87fd-ce9d39040d4d@infradead.org>
On Wed, Jan 03, 2024 at 04:19:03PM -0800, Randy Dunlap wrote:
> Hi,
>
> On 1/3/24 14:42, Gregory Price wrote:
> > This patch adds the new user-api argument structure intended for
> > set_mempolicy2 and mbind2.
> >
> > struct mpol_param {
> > __u16 mode;
> > __u16 mode_flags;
> > __s32 home_node; /* mbind2: policy home node */
> > __u16 pol_maxnodes;
> > __u8 resv[6];
> > __aligned_u64 *pol_nodes;
> > };
> >
> >
> > +Extended Mempolicy Arguments::
> > +
> > + struct mpol_param {
> > + __u16 mode;
> > + __u16 mode_flags;
> > + __s32 home_node; /* mbind2: set home node */
> > + __u64 pol_maxnodes;
> > + __aligned_u64 pol_nodes; /* nodemask pointer */
> > + };
> >
>
> Can you make the above documentation struct agree with the
> struct in the header below, please?
> (just a difference in the size of pol_maxnodes and the
> 'resv' bytes)
>
>
*facepalm* made a note to double check this, and then still didn't.
Thank you for reviewing. Will fix in the next pass of feedback.
~Gregory
next prev parent reply other threads:[~2024-01-04 2:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 22:41 [PATCH v6 00/12] mempolicy2, mbind2, and weighted interleave Gregory Price
2024-01-03 22:41 ` [PATCH v6 01/12] mm/mempolicy: implement the sysfs-based weighted_interleave interface Gregory Price
2024-01-03 22:41 ` [PATCH v6 02/12] mm/mempolicy: refactor a read-once mechanism into a function for re-use Gregory Price
2024-01-03 22:42 ` [PATCH v6 03/12] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving Gregory Price
2024-01-03 22:42 ` [PATCH v6 04/12] mm/mempolicy: refactor sanitize_mpol_flags for reuse Gregory Price
2024-01-03 22:42 ` [PATCH v6 05/12] mm/mempolicy: create struct mempolicy_param for creating new mempolicies Gregory Price
2024-01-03 22:42 ` [PATCH v6 06/12] mm/mempolicy: refactor kernel_get_mempolicy for code re-use Gregory Price
2024-01-03 22:42 ` [PATCH v6 07/12] mm/mempolicy: allow home_node to be set by mpol_new Gregory Price
2024-01-03 22:42 ` [PATCH v6 08/12] mm/mempolicy: add userland mempolicy arg structure Gregory Price
2024-01-04 0:19 ` Randy Dunlap
2024-01-04 2:03 ` Gregory Price [this message]
2024-01-03 22:42 ` [PATCH v6 09/12] mm/mempolicy: add set_mempolicy2 syscall Gregory Price
2024-01-03 22:42 ` [PATCH v6 10/12] mm/mempolicy: add get_mempolicy2 syscall Gregory Price
2024-01-03 22:42 ` [PATCH v6 11/12] mm/mempolicy: add the mbind2 syscall Gregory Price
2024-01-03 22:42 ` [PATCH v6 12/12] mm/mempolicy: extend mempolicy2 and mbind2 to support weighted interleave Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZYSB3kUOjCSo28h@memverge.com \
--to=gregory.price@memverge.com \
--cc=Hasan.Maruf@amd.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=emirakhur@micron.com \
--cc=fvdl@google.com \
--cc=gourry.memverge@gmail.com \
--cc=honggyu.kim@sk.com \
--cc=hpa@zytor.com \
--cc=hyeongtak.ji@sk.com \
--cc=jgroves@micron.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rakie.kim@sk.com \
--cc=ravis.opensrc@micron.com \
--cc=rdunlap@infradead.org \
--cc=seungjun.ha@samsung.com \
--cc=sthanneeru@micron.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vtavarespetr@micron.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).