From: "André Almeida" <andrealmeid@igalia.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
dvhart@infradead.org, dave@stgolabs.net, tglx@linutronix.de,
Andrew Morton <akpm@linux-foundation.org>,
axboe@kernel.dk, urezki@gmail.com, hch@infradead.org,
lstoakes@gmail.com, Arnd Bergmann <arnd@arndb.de>,
linux-api@vger.kernel.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org, malteskarupke@web.de
Subject: Re: [PATCH v2 03/14] futex: Flag conversion
Date: Mon, 7 Aug 2023 21:52:18 -0300 [thread overview]
Message-ID: <c4998f14-2804-4291-efe4-f42d07cd9343@igalia.com> (raw)
In-Reply-To: <20230807123322.952568452@infradead.org>
Em 07/08/2023 09:18, Peter Zijlstra escreveu:
> Futex has 3 sets of flags:
>
> - legacy futex op bits
> - futex2 flags
> - internal flags
>
> Add a few helpers to convert from the API flags into the internal
> flags.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
> ---
> kernel/futex/futex.h | 63 +++++++++++++++++++++++++++++++++++++++++++++---
> kernel/futex/syscalls.c | 24 ++++++------------
> kernel/futex/waitwake.c | 4 +--
> 3 files changed, 71 insertions(+), 20 deletions(-)
>
> --- a/kernel/futex/futex.h
> +++ b/kernel/futex/futex.h
> @@ -5,6 +5,7 @@
> #include <linux/futex.h>
> #include <linux/rtmutex.h>
> #include <linux/sched/wake_q.h>
> +#include <linux/compat.h>
>
> #ifdef CONFIG_PREEMPT_RT
> #include <linux/rcuwait.h>
> @@ -16,8 +17,15 @@
> * Futex flags used to encode options to functions and preserve them across
> * restarts.
> */
> +#define FLAGS_SIZE_8 0x00
> +#define FLAGS_SIZE_16 0x01
> +#define FLAGS_SIZE_32 0x02
> +#define FLAGS_SIZE_64 0x03
> +
Minor nit: for consistent, I would go with SIZE_U8, instead of SIZE_8
> +#define FLAGS_SIZE_MASK 0x03
> +
> #ifdef CONFIG_MMU
> -# define FLAGS_SHARED 0x01
> +# define FLAGS_SHARED 0x10
> #else
> /*
> * NOMMU does not have per process address space. Let the compiler optimize
> @@ -25,8 +33,57 @@
> */
> # define FLAGS_SHARED 0x00
> #endif
> -#define FLAGS_CLOCKRT 0x02
> -#define FLAGS_HAS_TIMEOUT 0x04
> +#define FLAGS_CLOCKRT 0x20
> +#define FLAGS_HAS_TIMEOUT 0x40
> +#define FLAGS_NUMA 0x80
> +
> +/* FUTEX_ to FLAGS_ */
> +static inline unsigned int futex_to_flags(unsigned int op)
> +{
> + unsigned int flags = FLAGS_SIZE_32;
> +
> + if (!(op & FUTEX_PRIVATE_FLAG))
> + flags |= FLAGS_SHARED;
> +
> + if (op & FUTEX_CLOCK_REALTIME)
> + flags |= FLAGS_CLOCKRT;
> +
> + return flags;
> +}
> +
> +/* FUTEX2_ to FLAGS_ */
> +static inline unsigned int futex2_to_flags(unsigned int flags2)
> +{
> + unsigned int flags = flags2 & FUTEX2_SIZE_MASK;
> +
> + if (!(flags2 & FUTEX2_PRIVATE))
> + flags |= FLAGS_SHARED;
> +
> + if (flags2 & FUTEX2_NUMA)
> + flags |= FLAGS_NUMA;
> +
> + return flags;
> +}
> +
> +static inline bool futex_flags_valid(unsigned int flags)
> +{
> + /* Only 64bit futexes for 64bit code */
> + if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) {
> + if ((flags & FLAGS_SIZE_MASK) == FLAGS_SIZE_64)
> + return false;
> + }
> +
> + /* Only 32bit futexes are implemented -- for now */
> + if ((flags & FLAGS_SIZE_MASK) != FLAGS_SIZE_32)
> + return false;
> +
> + return true;
> +} > +
> +static inline unsigned int futex_size(unsigned int flags)
> +{
> + return 1 << (flags & FLAGS_SIZE_MASK);
> +}
>
> #ifdef CONFIG_FAIL_FUTEX
> extern bool should_fail_futex(bool fshared);
> --- a/kernel/futex/syscalls.c
> +++ b/kernel/futex/syscalls.c
> @@ -1,6 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
>
> -#include <linux/compat.h>
> #include <linux/syscalls.h>
> #include <linux/time_namespace.h>
>
> @@ -85,15 +84,12 @@ SYSCALL_DEFINE3(get_robust_list, int, pi
> long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
> u32 __user *uaddr2, u32 val2, u32 val3)
> {
> + unsigned int flags = futex_to_flags(op);
> int cmd = op & FUTEX_CMD_MASK;
> - unsigned int flags = 0;
>
> - if (!(op & FUTEX_PRIVATE_FLAG))
> - flags |= FLAGS_SHARED;
> -
> - if (op & FUTEX_CLOCK_REALTIME) {
> - flags |= FLAGS_CLOCKRT;
> - if (cmd != FUTEX_WAIT_BITSET && cmd != FUTEX_WAIT_REQUEUE_PI &&
> + if (flags & FLAGS_CLOCKRT) {
> + if (cmd != FUTEX_WAIT_BITSET &&
> + cmd != FUTEX_WAIT_REQUEUE_PI &&
> cmd != FUTEX_LOCK_PI2)
> return -ENOSYS;
> }
> @@ -201,21 +197,19 @@ static int futex_parse_waitv(struct fute
> unsigned int i;
>
> for (i = 0; i < nr_futexes; i++) {
> + unsigned int flags;
> +
> if (copy_from_user(&aux, &uwaitv[i], sizeof(aux)))
> return -EFAULT;
>
> if ((aux.flags & ~FUTEX2_VALID_MASK) || aux.__reserved)
> return -EINVAL;
>
> - if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) {
> - if ((aux.flags & FUTEX2_SIZE_MASK) == FUTEX2_SIZE_U64)
> - return -EINVAL;
> - }
> -
> - if ((aux.flags & FUTEX2_SIZE_MASK) != FUTEX2_SIZE_U32)
> + flags = futex2_to_flags(aux.flags);
> + if (!futex_flags_valid(flags))
> return -EINVAL;
>
> - futexv[i].w.flags = aux.flags;
> + futexv[i].w.flags = flags;
> futexv[i].w.val = aux.val;
> futexv[i].w.uaddr = aux.uaddr;
> futexv[i].q = futex_q_init;
> --- a/kernel/futex/waitwake.c
> +++ b/kernel/futex/waitwake.c
> @@ -419,11 +419,11 @@ static int futex_wait_multiple_setup(str
> */
> retry:
> for (i = 0; i < count; i++) {
> - if ((vs[i].w.flags & FUTEX_PRIVATE_FLAG) && retry)
> + if (!(vs[i].w.flags & FLAGS_SHARED) && retry)
> continue;
>
> ret = get_futex_key(u64_to_user_ptr(vs[i].w.uaddr),
> - !(vs[i].w.flags & FUTEX_PRIVATE_FLAG),
> + vs[i].w.flags & FLAGS_SHARED,
> &vs[i].q.key, FUTEX_READ);
>
> if (unlikely(ret))
>
>
next prev parent reply other threads:[~2023-08-08 0:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 12:18 [PATCH v2 00/14] futex: More futex2 bits Peter Zijlstra
2023-08-07 12:18 ` [PATCH v2 01/14] futex: Clarify FUTEX2 flags Peter Zijlstra
2023-08-07 23:51 ` André Almeida
2023-08-07 12:18 ` [PATCH v2 02/14] futex: Extend the " Peter Zijlstra
2023-08-07 18:56 ` Thomas Gleixner
2023-08-08 0:02 ` André Almeida
2023-08-07 12:18 ` [PATCH v2 03/14] futex: Flag conversion Peter Zijlstra
2023-08-07 18:58 ` Thomas Gleixner
2023-08-08 0:52 ` André Almeida [this message]
2023-08-07 12:18 ` [PATCH v2 04/14] futex: Validate futex value against futex size Peter Zijlstra
2023-08-07 12:18 ` [PATCH v2 05/14] futex: Add sys_futex_wake() Peter Zijlstra
2023-08-07 19:00 ` Thomas Gleixner
2023-08-09 22:25 ` André Almeida
2023-08-10 12:13 ` Peter Zijlstra
2023-08-10 17:01 ` André Almeida
2023-08-07 12:18 ` [PATCH v2 06/14] futex: Add sys_futex_wait() Peter Zijlstra
2023-08-07 12:18 ` [PATCH v2 07/14] futex: Propagate flags into get_futex_key() Peter Zijlstra
2023-08-07 12:18 ` [PATCH v2 08/14] futex: Add flags2 argument to futex_requeue() Peter Zijlstra
2023-08-07 19:01 ` Thomas Gleixner
2023-08-07 12:18 ` [PATCH v2 09/14] futex: Add sys_futex_requeue() Peter Zijlstra
2023-08-07 19:05 ` Thomas Gleixner
2023-08-07 12:18 ` [PATCH v2 10/14] mm: Add vmalloc_huge_node() Peter Zijlstra
2023-08-07 12:18 ` [PATCH v2 11/14] futex: Implement FUTEX2_NUMA Peter Zijlstra
2023-08-07 21:11 ` Thomas Gleixner
2023-08-08 8:54 ` Peter Zijlstra
2023-08-08 9:12 ` Thomas Gleixner
2023-08-07 12:18 ` [PATCH v2 12/14] futex: Propagate flags into futex_get_value_locked() Peter Zijlstra
2023-08-07 21:12 ` Thomas Gleixner
2023-08-07 12:18 ` [PATCH v2 13/14] futex: Enable FUTEX2_{8,16} Peter Zijlstra
2023-08-07 21:15 ` Thomas Gleixner
2023-08-07 12:18 ` [PATCH v2 14/14] futex,selftests: Extend the futex selftests Peter Zijlstra
2023-08-08 20:32 ` [PATCH v2 00/14] futex: More futex2 bits Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4998f14-2804-4291-efe4-f42d07cd9343@igalia.com \
--to=andrealmeid@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=malteskarupke@web.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).