From: Luis Chamberlain <mcgrof@kernel.org>
To: masahiroy@kernel.org, deller@gmx.de
Cc: mcgrof@kernel.org, arnd@arndb.de, linux-arch@vger.kernel.org,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] modules: few of alignment fixes
Date: Mon, 29 Jan 2024 11:26:39 -0800 [thread overview]
Message-ID: <20240129192644.3359978-1-mcgrof@kernel.org> (raw)
Helge Deller had written a series of patches to fix a few
misalignemnt annotations in the kernel [0]. Three of these
patches were tagged as being stable candidates. Because of these
annotation I suggested proof of the imapact, however we did not
easily have a way to verify the value / impact of fixing a few
misaligment changes in the kernel for modules.
For the more hotpath alignment fix Helge had I suggested we could
easily test this by stress testing find_symbol() with a few set of
modules. This adds such tests to allow us to both allow us to test
the impact of such possible fix, and also while at it, let's us
test future improvements on the find_symbol() path.
Changes on this v2:
- Adds new selftest for kallsyms
- Drops patch #1 as Masahiro Yamada already applied it to linux-kbuild/fixes
- Removes stable tags
- Drops patch #3 as it was not needed
- Adds a new patch with the issues noted by Helge as a fix
to commit f3304ecd7f06 ("linux/export: use inline assembler to
populate symbol CRCs") as noted by Masahiro Yamada
- Adds selftest impact on x86_64 for patch #2, this really should
be tested on parisc though as that's an example architecture
where we could see perhaps more improvement
[0] https://lkml.kernel.org/r/20231122221814.139916-1-deller@kernel.org
Masahiro, if there no issues feel free to take this or I can take them in
too via the modules-next tree. Lemme know!
Helge Deller (2):
modules: Ensure 64-bit alignment on __ksymtab_* sections
modules: Add missing entry for __ex_table
Luis Chamberlain (2):
selftests: add new kallsyms selftests
vmlinux.lds.h: add missing alignment for symbol CRCs
include/linux/export-internal.h | 1 +
lib/Kconfig.debug | 103 ++++++++++++++
lib/Makefile | 1 +
lib/tests/Makefile | 1 +
lib/tests/module/.gitignore | 4 +
lib/tests/module/Makefile | 15 ++
lib/tests/module/gen_test_kallsyms.sh | 128 ++++++++++++++++++
scripts/module.lds.S | 9 +-
tools/testing/selftests/module/Makefile | 12 ++
tools/testing/selftests/module/config | 3 +
tools/testing/selftests/module/find_symbol.sh | 81 +++++++++++
11 files changed, 354 insertions(+), 4 deletions(-)
create mode 100644 lib/tests/Makefile
create mode 100644 lib/tests/module/.gitignore
create mode 100644 lib/tests/module/Makefile
create mode 100755 lib/tests/module/gen_test_kallsyms.sh
create mode 100644 tools/testing/selftests/module/Makefile
create mode 100644 tools/testing/selftests/module/config
create mode 100755 tools/testing/selftests/module/find_symbol.sh
--
2.42.0
next reply other threads:[~2024-01-29 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 19:26 Luis Chamberlain [this message]
2024-01-29 19:26 ` [PATCH v2 1/4] selftests: add new kallsyms selftests Luis Chamberlain
2024-01-29 19:26 ` [PATCH v2 2/4] modules: Ensure 64-bit alignment on __ksymtab_* sections Luis Chamberlain
2024-01-29 19:26 ` [PATCH v2 3/4] vmlinux.lds.h: add missing alignment for symbol CRCs Luis Chamberlain
2024-01-29 19:26 ` [PATCH v2 4/4] modules: Add missing entry for __ex_table Luis Chamberlain
2024-01-31 22:11 ` [PATCH v2 0/3] modules: few of alignment fixes Luis Chamberlain
2024-02-01 18:05 ` Luis Chamberlain
2024-02-02 15:20 ` Masahiro Yamada
2024-02-02 18:23 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129192644.3359978-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).