From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E83C4332F for ; Mon, 27 Dec 2021 17:15:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbhL0RPa (ORCPT ); Mon, 27 Dec 2021 12:15:30 -0500 Received: from mail-qt1-f180.google.com ([209.85.160.180]:44964 "EHLO mail-qt1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbhL0RPa (ORCPT ); Mon, 27 Dec 2021 12:15:30 -0500 Received: by mail-qt1-f180.google.com with SMTP id a1so13981276qtx.11; Mon, 27 Dec 2021 09:15:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mtgQp7E+XHWylh821kSXZHujAj5pCd79Pzv+DDY2bEU=; b=cTY0I7ab+1YISy9GG7AM0ilwNNMJBKFARIkEJMRtYhsDFgFnL/tcKssbx1+ecnu5SD rh631Zo4pOHjxCpN1zzW58PlNyOkLlooE2Lr0XV1muAXrkesa+FsXmGOaJw4Mjst3n/Y DzcUcyfm0EMJKN7C+yTq7P0uu4Z6NEAyYYvDz7g2baIgN0CnsTGeYYuzJjh11Aik1AGm tvsm421MD6PLXW0vIA6M/cVd8/0L6KAi5YcE9hBYbIo2jxmUbvUDEmaJzkk3xHVN79Eu e/251c0VmRV9ldJ+mWkutdk3xaDcZeUrsTxc9n+t/zvjs068QNJ7cCDl3UAsQhd61Qln KQDg== X-Gm-Message-State: AOAM533bPlXENnL5u0QrxTyisqS66b+/NrUVy2Ntd36Gga6DSc7mJRES QP/o95xMdjI0tqoi90wyy07JHgCZnmipUDW7ULI= X-Google-Smtp-Source: ABdhPJzA0UGsW2BMjYh4XhxHxtQu5xuUJBsEKsGOHY8rU94CjJKL3IsMfTI+JhA0Q5Zt69+rfrdTsyx47n0p+gK10nc= X-Received: by 2002:ac8:46cc:: with SMTP id h12mr15513581qto.417.1640625329642; Mon, 27 Dec 2021 09:15:29 -0800 (PST) MIME-Version: 1.0 References: <20211227164317.4146918-1-schnelle@linux.ibm.com> <20211227164317.4146918-4-schnelle@linux.ibm.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 27 Dec 2021 18:15:18 +0100 Message-ID: Subject: Re: [RFC 03/32] ACPI: Kconfig: add HAS_IOPORT dependencies To: "Rafael J. Wysocki" , Niklas Schnelle Cc: Arnd Bergmann , Bjorn Helgaas , John Garry , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Len Brown , Linux Kernel Mailing List , linux-arch , Linux PCI , linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org, ACPI Devel Maling List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, Dec 27, 2021 at 6:12 PM Rafael J. Wysocki wrote: > > On Mon, Dec 27, 2021 at 6:02 PM Niklas Schnelle wrote: > > > > On Mon, 2021-12-27 at 17:47 +0100, Rafael J. Wysocki wrote: > > > On Mon, Dec 27, 2021 at 5:44 PM Niklas Schnelle wrote: > > > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > > > not being declared. As ACPI always uses I/O port access > > > > > > The ARM64 people may not agree with this. > > > > Maybe my wording is bad. This is my rewording of what Arnd had in his > > original mail: "The ACPI subsystem needs access to I/O ports, so that > > also gets a dependency."( > > https://lore.kernel.org/lkml/CAK8P3a0MNbx-iuzW_-=0ab6-TTZzwV-PT_6gAC1Gp5PgYyHcrA@mail.gmail.com/ > > ). > > And my point is that on ARM64 the ACPI subsystem does not need to > access IO ports. > > It may not even need to access them on x86, but that depends on the > platform firmware in use. > > If arm64 is going to set HAS_IOPORT, then fine, but is it (and this > applies to ia64 too)? > > > > > > > > we depend on HAS_IOPORT unconditionally. > > > > > > > > Co-developed-by: Arnd Bergmann > > > > Signed-off-by: Arnd Bergmann > > > > Signed-off-by: Niklas Schnelle > > > > --- > > > > drivers/acpi/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > > > > index cdbdf68bd98f..b57f15817ede 100644 > > > > --- a/drivers/acpi/Kconfig > > > > +++ b/drivers/acpi/Kconfig > > > > @@ -9,6 +9,7 @@ config ARCH_SUPPORTS_ACPI > > > > menuconfig ACPI > > > > bool "ACPI (Advanced Configuration and Power Interface) Support" > > > > depends on ARCH_SUPPORTS_ACPI Besides, I'm not sure why ARCH_SUPPORTS_ACPI cannot cover this new dependency. > > > > + depends on HAS_IOPORT > > > > select PNP > > > > select NLS > > > > default y if X86 > > > > -- > > > > 2.32.0 > > > > > >