From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EC9C433ED for ; Sat, 15 May 2021 20:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7244261370 for ; Sat, 15 May 2021 20:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbhEOUSy (ORCPT ); Sat, 15 May 2021 16:18:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:38882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234840AbhEOUSv (ORCPT ); Sat, 15 May 2021 16:18:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E63696121E; Sat, 15 May 2021 20:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621109857; bh=Z9NQzsSFCaSLn3jMjEHhBdcoFhlXWyGQ4ZxdOXx3NYA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=traaZJipL6kqLOa/FfhL7XkYEVzXJ6VK11z51O0PmjgxeOXOHzJig1nqPACsvqn73 /Prt6FS/O4Vf4P/igam5GkrfH1hWpG4bOJPXcf7O0vB7zKbcx4YxuecdlNGJOLFZar JBVC7ml8MRpHpL5e0rWB5Ek2FvUlqXujauJAM0uGpYPVu0R/dz/aFLBC2qUvjMKO1U veZKr21xLUb95Q3LTpDa4IeGaEjsb2HteTWWnrn58wPw59An/b2OL+zFiOs0vQnybx B5OcYcjaAgKEANlvlbfTYNmlvnx9CK3G4RbmmAZWGE0X5f0iCg/DpomxBmfdgZEz4G oMg4r1ctGWdUA== Received: by mail-wr1-f43.google.com with SMTP id z17so2415856wrq.7; Sat, 15 May 2021 13:17:37 -0700 (PDT) X-Gm-Message-State: AOAM533ZpMGkRxZ0leBOl9xWfEIlJUtLpfPkffT9+RMzGxC/YLp+fYKR 2bFHeB7ZCmyqc9Og4jPwxQKLgPvP5BlKt5iNpfU= X-Google-Smtp-Source: ABdhPJxm+4q3De3RBJDfQGvWSlPiUE6c2DBBt55wdtCluO9aXAU9V+hkjWv4pM6qjaKQ5DGkyvnlFE5bXR41SbZuXEc= X-Received: by 2002:a5d:5404:: with SMTP id g4mr1680204wrv.286.1621109856628; Sat, 15 May 2021 13:17:36 -0700 (PDT) MIME-Version: 1.0 References: <20210514100106.3404011-1-arnd@kernel.org> <20210514100106.3404011-13-arnd@kernel.org> <9f763da3-25c6-24e7-91e9-f3016a85f9f7@infradead.org> In-Reply-To: <9f763da3-25c6-24e7-91e9-f3016a85f9f7@infradead.org> From: Arnd Bergmann Date: Sat, 15 May 2021 22:16:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 12/13] asm-generic: uaccess: 1-byte access is always aligned To: Randy Dunlap Cc: linux-arch , Linus Torvalds , Vineet Gupta , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Sat, May 15, 2021 at 8:41 PM Randy Dunlap wrote: > On 5/14/21 3:01 AM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > diff --git a/include/asm-generic/uaccess.h b/include/asm-generic/uaccess.h > > index 4973328f3c6e..7e903e450659 100644 > > --- a/include/asm-generic/uaccess.h > > +++ b/include/asm-generic/uaccess.h > > @@ -19,7 +19,7 @@ __get_user_fn(size_t size, const void __user *from, void *to) > > > > switch (size) { > > case 1: > > - *(u8 *)to = get_unaligned((u8 __force *)from); > > + *(u8 *)to = *((u8 __force *)from); > > return 0; > > case 2: > > *(u16 *)to = get_unaligned((u16 __force *)from); > > @@ -45,7 +45,7 @@ __put_user_fn(size_t size, void __user *to, void *from) > > > > switch (size) { > > case 1: > > - put_unaligned(*(u8 *)from, (u8 __force *)to); > > + *(*(u8 *)from, (u8 __force *)to); > > Should that be from = > ? Thanks a lot for catching the typo! Changed now to *(u8 __force *)to = *(u8 *)from; For some reason neither my own build testing nor the kernel build bot caught it so far. Arnd