From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31951C433ED for ; Fri, 14 May 2021 19:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02458613D3 for ; Fri, 14 May 2021 19:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233048AbhENTeP (ORCPT ); Fri, 14 May 2021 15:34:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:53670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231386AbhENTeO (ORCPT ); Fri, 14 May 2021 15:34:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C8FB06145A; Fri, 14 May 2021 19:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621020782; bh=sx6RnRTXG/HkUYbZ66bme4Ihr6YCIRDKjve7uvyFxHE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Kf5jsZXI52Zq2tpRgMl1O8c/U7y8d0w9MTmfdlRsUujEeAawhwUIMMGIQtMlsZQR+ 09M/wvcClTYpMdPwODUMv1lEUqwsxZg8kN+M27STmCVk1mXGfnwxvYTILPmrgioIip 2DidMQ/s9r1u10t8JprtlXHoYMmOHC5NzqP5zI5qWxESG0s76XUoFdFhzvPxB2OknV Wl1y4oD0rWxRYnRD7OLp1efXk9B2P86nK8hne1Rf0EOQvqeFJm0vGI8G2NBqcS9E51 pNUbKOerRoDcTyncAbJOnEzan5RkSIAHrktjzHjFuDRXPTX8fx4UJMFbBk15mWJGWi 2t6jgV3Fc82HA== Received: by mail-wr1-f48.google.com with SMTP id s8so282442wrw.10; Fri, 14 May 2021 12:33:02 -0700 (PDT) X-Gm-Message-State: AOAM532MquXo4CcXnU0aIaGz9PJnnz6tfG6hOFSdWxKGnAjjpUcABeTd vuUvPo8OM9pRpqesSqxyehhCk9T3N9x+Nmj3WE0= X-Google-Smtp-Source: ABdhPJwCQ1F0CBUPxIsNYOfoW01L5a5C+nTIh8ZsdXu8MlaXBtReQ+mP8NigDxBA9czvxj+u/ONPbc8umn+Z9hfl/zY= X-Received: by 2002:a5d:6dc4:: with SMTP id d4mr62128225wrz.105.1621020781452; Fri, 14 May 2021 12:33:01 -0700 (PDT) MIME-Version: 1.0 References: <20210514100106.3404011-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 14 May 2021 21:31:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/13] Unify asm/unaligned.h around struct helper To: Linus Torvalds Cc: linux-arch , Vineet Gupta , Amitkumar Karwar , Benjamin Herrenschmidt , Borislav Petkov , Eric Dumazet , Florian Fainelli , Ganapathi Bhat , Geert Uytterhoeven , "H. Peter Anvin" , Ingo Molnar , Jakub Kicinski , James Morris , Jens Axboe , John Johansen , Jonas Bonn , Kalle Valo , Michael Ellerman , Paul Mackerras , Rich Felker , "Richard Russon (FlatCap)" , Russell King , "Serge E. Hallyn" , Sharvari Harisangam , Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Vladimir Oltean , Xinming Hu , Yoshinori Sato , "the arch/x86 maintainers" , Linux Kernel Mailing List , Linux ARM , linux-m68k , Linux Crypto Mailing List , Openrisc , linuxppc-dev , Linux-sh list , linux-sparc , linux-ntfs-dev@lists.sourceforge.net, linux-block , linux-wireless , Netdev , LSM List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, May 14, 2021 at 7:32 PM Linus Torvalds wrote: > > On Fri, May 14, 2021 at 3:02 AM Arnd Bergmann wrote: > > > > I've included this version in the asm-generic tree for 5.14 already, > > addressing the few issues that were pointed out in the RFC. If there > > are any remaining problems, I hope those can be addressed as follow-up > > patches. > > This continues to look great to me, and now has the even simpler > remaining implementation. > > I'd be tempted to just pull it in for 5.13, but I guess we don't > actually have any _outstanding_ bug in this area (the bug was in our > zlib code, required -O3 to trigger, has been fixed now, and the biggy > case didn't even use "get_unaligned()"). > > So I guess your 5.14 timing is the right thing to do. Yes, I think that's best, just in case something does come up. While all the object code I looked at does appear better, this is one of those areas that can be hard to pinpoint if we hit a regression in a particular combination of architecture+compiler+source file. I have pushed a signed tag to https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git asm-generic-unaligned-5.14 and plan to send that in the 5.14 merge window unless you decide to take it now after all. Arnd