From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: kernel test robot <lkp@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
<amd-gfx@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>, <linux-arch@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
<nouveau@lists.freedesktop.org>
Subject: Re: [linux-next:master] BUILD REGRESSION 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a
Date: Fri, 3 May 2024 13:23:43 +0530 [thread overview]
Message-ID: <a0daf2d5-4c72-4d96-a8d4-b15adb7252d5@quicinc.com> (raw)
In-Reply-To: <2024050314-knelt-sandpaper-3884@gregkh>
On 5/3/2024 11:58 AM, Greg KH wrote:
> On Fri, May 03, 2024 at 11:30:50AM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 5/3/2024 10:42 AM, Greg KH wrote:
>>> Ok, I'm getting tired of seeing these for the USB portion of the tree,
>>> so I went to look for:
>>>
>>> On Fri, May 03, 2024 at 04:44:42AM +0800, kernel test robot wrote:
>>>> |-- arc-randconfig-002-20240503
>>>> | `-- drivers-usb-dwc3-core.c:warning:variable-hw_mode-set-but-not-used
>>>
>>> This warning (same for all arches), but can't seem to find it anywhere.
>>>
>>> Any hints as to where it would be?
>>>
>>
>> Hi Greg,
>>
>> I think the hw_mode was not removed in hs_phy_setup and left unused.
>>
>> Thinh reported the same when there was a merge conflict into linux next
>> (that the hw_mode variable was removed in ss_phy_setup and should be removed
>> in hs_phy_setup as well):
>>
>> https://lore.kernel.org/all/20240426213923.tyeddub4xszypeju@synopsys.com/
>>
>> Perhaps that was missed ?
>
> Must have been. I need it in a format that it can be applied in (a
> 2-way diff can't apply...)
>
I just checked it with W=1 and it is causing the issue:
/local/mnt/workspace/krishna/linux-next/skales_test/skales/kernel/drivers/usb/dwc3/core.c:
In function 'dwc3_hs_phy_setup':
/local/mnt/workspace/krishna/linux-next/skales_test/skales/kernel/drivers/usb/dwc3/core.c:679:15:
warning: variable 'hw_mode' set but not used [-Wunused-but-set-variable]
unsigned int hw_mode;
^
I can send a patch to fix it up. Also, just wanted to confirm if I skip
the fixes and CC tags as the main patch wasn't yet merged into any
stable trees ?
Regards,
Krishna,
prev parent reply other threads:[~2024-05-03 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 20:44 [linux-next:master] BUILD REGRESSION 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a kernel test robot
2024-05-03 5:12 ` Greg KH
2024-05-03 6:00 ` Krishna Kurapati PSSNV
2024-05-03 6:28 ` Greg KH
2024-05-03 7:53 ` Krishna Kurapati PSSNV [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0daf2d5-4c72-4d96-a8d4-b15adb7252d5@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).