* [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings
@ 2024-02-24 10:37 Zev Weiss
2024-02-24 19:16 ` Conor Dooley
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Zev Weiss @ 2024-02-24 10:37 UTC (permalink / raw
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley
Cc: Zev Weiss, Andrew Jeffery, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
Due to the way i2c driver matching works (falling back to the driver's
id_table if of_match_table fails) this didn't actually cause any
misbehavior, but let's add the vendor prefixes so things actually work
the way they were intended to.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts | 4 ++--
arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
index 4554abf0c7cd..9aa2de3723b5 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
@@ -98,14 +98,14 @@ w83773g@4c {
/* IPB PMIC */
lm25066@40 {
- compatible = "lm25066";
+ compatible = "ti,lm25066";
reg = <0x40>;
shunt-resistor-micro-ohms = <1000>;
};
/* 12VSB PMIC */
lm25066@41 {
- compatible = "lm25066";
+ compatible = "ti,lm25066";
reg = <0x41>;
shunt-resistor-micro-ohms = <10000>;
};
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
index 6600f7e9bf5e..e830fec0570f 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
@@ -14,7 +14,7 @@ efuse##n { \
#define EFUSE(hexaddr, num) \
efuse@##hexaddr { \
- compatible = "lm25066"; \
+ compatible = "ti,lm25066"; \
reg = <0x##hexaddr>; \
shunt-resistor-micro-ohms = <675>; \
regulators { \
--
2.43.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings
2024-02-24 10:37 [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings Zev Weiss
@ 2024-02-24 19:16 ` Conor Dooley
2024-04-24 6:55 ` Krzysztof Kozlowski
2024-04-24 6:58 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-02-24 19:16 UTC (permalink / raw
To: Zev Weiss
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2029 bytes --]
On Sat, Feb 24, 2024 at 02:37:07AM -0800, Zev Weiss wrote:
> Due to the way i2c driver matching works (falling back to the driver's
> id_table if of_match_table fails) this didn't actually cause any
> misbehavior, but let's add the vendor prefixes so things actually work
> the way they were intended to.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Oh sweet, I was just about to go off and write this patch - thanks!
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts | 4 ++--
> arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> index 4554abf0c7cd..9aa2de3723b5 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
> @@ -98,14 +98,14 @@ w83773g@4c {
>
> /* IPB PMIC */
> lm25066@40 {
> - compatible = "lm25066";
> + compatible = "ti,lm25066";
> reg = <0x40>;
> shunt-resistor-micro-ohms = <1000>;
> };
>
> /* 12VSB PMIC */
> lm25066@41 {
> - compatible = "lm25066";
> + compatible = "ti,lm25066";
> reg = <0x41>;
> shunt-resistor-micro-ohms = <10000>;
> };
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> index 6600f7e9bf5e..e830fec0570f 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts
> @@ -14,7 +14,7 @@ efuse##n { \
>
> #define EFUSE(hexaddr, num) \
> efuse@##hexaddr { \
> - compatible = "lm25066"; \
> + compatible = "ti,lm25066"; \
> reg = <0x##hexaddr>; \
> shunt-resistor-micro-ohms = <675>; \
> regulators { \
> --
> 2.43.2
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings
2024-02-24 10:37 [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings Zev Weiss
2024-02-24 19:16 ` Conor Dooley
@ 2024-04-24 6:55 ` Krzysztof Kozlowski
2024-04-24 6:58 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-24 6:55 UTC (permalink / raw
To: Zev Weiss, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley
Cc: Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed,
linux-kernel
On 24/02/2024 11:37, Zev Weiss wrote:
> Due to the way i2c driver matching works (falling back to the driver's
> id_table if of_match_table fails) this didn't actually cause any
> misbehavior, but let's add the vendor prefixes so things actually work
> the way they were intended to.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings
2024-02-24 10:37 [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings Zev Weiss
2024-02-24 19:16 ` Conor Dooley
2024-04-24 6:55 ` Krzysztof Kozlowski
@ 2024-04-24 6:58 ` Krzysztof Kozlowski
2024-04-26 1:00 ` Andrew Jeffery
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-24 6:58 UTC (permalink / raw
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Zev Weiss
Cc: Krzysztof Kozlowski, Andrew Jeffery, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
On Sat, 24 Feb 2024 02:37:07 -0800, Zev Weiss wrote:
> Due to the way i2c driver matching works (falling back to the driver's
> id_table if of_match_table fails) this didn't actually cause any
> misbehavior, but let's add the vendor prefixes so things actually work
> the way they were intended to.
>
>
Two months passed, no replies from maintainers about picking it up. Dunno,
looks abandoned, so let me grab this. If anyone else wants to pick it up, let
me know.
Applied, thanks!
[1/1] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings
https://git.kernel.org/krzk/linux-dt/c/1afe35e54a89d762f1cf71da1ef29be2c387be35
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings
2024-04-24 6:58 ` Krzysztof Kozlowski
@ 2024-04-26 1:00 ` Andrew Jeffery
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2024-04-26 1:00 UTC (permalink / raw
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Joel Stanley, Zev Weiss
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
On Wed, 2024-04-24 at 08:58 +0200, Krzysztof Kozlowski wrote:
> On Sat, 24 Feb 2024 02:37:07 -0800, Zev Weiss wrote:
> > Due to the way i2c driver matching works (falling back to the driver's
> > id_table if of_match_table fails) this didn't actually cause any
> > misbehavior, but let's add the vendor prefixes so things actually work
> > the way they were intended to.
> >
> >
>
> Two months passed, no replies from maintainers about picking it up. Dunno,
> looks abandoned, so let me grab this. If anyone else wants to pick it up, let
> me know.
Sorry, another one that fell in the hole mentioned previously.
I'm okay with it going via your tree if there are no conflicts.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-26 1:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-24 10:37 [PATCH] ARM: dts: aspeed: Add vendor prefixes to lm25066 compat strings Zev Weiss
2024-02-24 19:16 ` Conor Dooley
2024-04-24 6:55 ` Krzysztof Kozlowski
2024-04-24 6:58 ` Krzysztof Kozlowski
2024-04-26 1:00 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).