* [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema
@ 2024-04-29 19:58 Nathan Morrisson
2024-04-29 19:58 ` [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC Nathan Morrisson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Nathan Morrisson @ 2024-04-29 19:58 UTC (permalink / raw
To: lee, robh, krzk+dt, conor+dt, nm, vigneshr, kristo, j-keerthy
Cc: devicetree, linux-kernel, linux-arm-kernel, upstream, w.egorov
Convert the lp873x binding to DT schema format. The gpio-controller
and #gpio-cells properties were removed from required because using
the device as a GPIO controller is optional.
Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
---
v2:
- Added "mfd:" to subject prefix
- Added vendor TI to file name
- Updated title to match hardware
- Removed | where we do not need to preserve formatting
- Added *-in-supply back to required properties, they should not have been removed
- Added explanation for why gpio properties were removed from required
- Updated the example to be more generic and got rid of unnecessary i2c node
.../devicetree/bindings/mfd/lp873x.txt | 67 -----------
.../devicetree/bindings/mfd/ti,lp8732.yaml | 112 ++++++++++++++++++
2 files changed, 112 insertions(+), 67 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/lp873x.txt
create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp8732.yaml
diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt
deleted file mode 100644
index ae9cf39bd101..000000000000
--- a/Documentation/devicetree/bindings/mfd/lp873x.txt
+++ /dev/null
@@ -1,67 +0,0 @@
-TI LP873X PMIC MFD driver
-
-Required properties:
- - compatible: "ti,lp8732", "ti,lp8733"
- - reg: I2C slave address.
- - gpio-controller: Marks the device node as a GPIO Controller.
- - #gpio-cells: Should be two. The first cell is the pin number and
- the second cell is used to specify flags.
- See ../gpio/gpio.txt for more information.
- - xxx-in-supply: Phandle to parent supply node of each regulator
- populated under regulators node. xxx can be
- buck0, buck1, ldo0 or ldo1.
- - regulators: List of child nodes that specify the regulator
- initialization data.
-Example:
-
-pmic: lp8733@60 {
- compatible = "ti,lp8733";
- reg = <0x60>;
- gpio-controller;
- #gpio-cells = <2>;
-
- buck0-in-supply = <&vsys_3v3>;
- buck1-in-supply = <&vsys_3v3>;
- ldo0-in-supply = <&vsys_3v3>;
- ldo1-in-supply = <&vsys_3v3>;
-
- regulators {
- lp8733_buck0: buck0 {
- regulator-name = "lp8733-buck0";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <1400000>;
- regulator-min-microamp = <1500000>;
- regulator-max-microamp = <4000000>;
- regulator-ramp-delay = <10000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- lp8733_buck1: buck1 {
- regulator-name = "lp8733-buck1";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <1400000>;
- regulator-min-microamp = <1500000>;
- regulator-max-microamp = <4000000>;
- regulator-ramp-delay = <10000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- lp8733_ldo0: ldo0 {
- regulator-name = "lp8733-ldo0";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <3000000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- lp8733_ldo1: ldo1 {
- regulator-name = "lp8733-ldo1";
- regulator-min-microvolt = <800000>;
- regulator-max-microvolt = <3000000>;
- regulator-always-on;
- regulator-boot-on;
- };
- };
-};
diff --git a/Documentation/devicetree/bindings/mfd/ti,lp8732.yaml b/Documentation/devicetree/bindings/mfd/ti,lp8732.yaml
new file mode 100644
index 000000000000..9a90cee2b545
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ti,lp8732.yaml
@@ -0,0 +1,112 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ti,lp8732.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI LP873X Power Management Integrated Circuit
+
+maintainers:
+ - J Keerthy <j-keerthy@ti.com>
+
+description:
+ PMIC with two high-current buck converters and two linear regulators.
+
+properties:
+ compatible:
+ enum:
+ - ti,lp8732
+ - ti,lp8733
+
+ reg:
+ maxItems: 1
+
+ gpio-controller: true
+
+ '#gpio-cells':
+ const: 2
+
+ regulators:
+ description:
+ List of child nodes that specify the regulator initialization data.
+ type: object
+ patternProperties:
+ "^buck[01]|ldo[01]$":
+ type: object
+ $ref: /schemas/regulator/regulator.yaml#
+ unevaluatedProperties: false
+ additionalProperties: false
+
+patternProperties:
+ '^(buck[01]|ldo[01])-in-supply$':
+ description: Phandle to parent supply of each regulator populated under regulators node.
+
+required:
+ - compatible
+ - reg
+ - regulators
+ - buck0-in-supply
+ - buck1-in-supply
+ - ldo0-in-supply
+ - ldo1-in-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic: pmic@60 {
+ compatible = "ti,lp8733";
+ reg = <0x60>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ buck0-in-supply = <&vsys_3v3>;
+ buck1-in-supply = <&vsys_3v3>;
+ ldo0-in-supply = <&vsys_3v3>;
+ ldo1-in-supply = <&vsys_3v3>;
+
+ regulators {
+ buck0: buck0 {
+ regulator-name = "buck0";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-min-microamp = <1500000>;
+ regulator-max-microamp = <4000000>;
+ regulator-ramp-delay = <10000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ buck1: buck1 {
+ regulator-name = "buck1";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-min-microamp = <1500000>;
+ regulator-max-microamp = <4000000>;
+ regulator-ramp-delay = <10000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo0: ldo0 {
+ regulator-name = "ldo0";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1: ldo1 {
+ regulator-name = "ldo1";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+ };
+ };
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC
2024-04-29 19:58 [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema Nathan Morrisson
@ 2024-04-29 19:58 ` Nathan Morrisson
2024-05-02 7:25 ` Wadim Egorov
2024-06-13 8:57 ` (subset)[PATCH " Vignesh Raghavendra
2024-04-30 7:44 ` [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema Krzysztof Kozlowski
2024-05-02 17:24 ` (subset) " Lee Jones
2 siblings, 2 replies; 6+ messages in thread
From: Nathan Morrisson @ 2024-04-29 19:58 UTC (permalink / raw
To: lee, robh, krzk+dt, conor+dt, nm, vigneshr, kristo, j-keerthy
Cc: devicetree, linux-kernel, linux-arm-kernel, upstream, w.egorov
Add a PMIC node to the phycore-am64 device tree.
Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
---
v2: No change
.../boot/dts/ti/k3-am64-phycore-som.dtsi | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
index 125e507966fb..2c3b20ddfb8b 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
@@ -265,6 +265,50 @@ i2c_som_rtc: rtc@52 {
interrupts = <70 IRQ_TYPE_EDGE_FALLING>;
wakeup-source;
};
+
+ pmic@61 {
+ compatible = "ti,lp8733";
+ reg = <0x61>;
+
+ buck0-in-supply = <&vcc_5v0_som>;
+ buck1-in-supply = <&vcc_5v0_som>;
+ ldo0-in-supply = <&vdd_3v3>;
+ ldo1-in-supply = <&vdd_3v3>;
+
+ regulators {
+ vdd_core: buck0 {
+ regulator-name = "VDD_CORE";
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <750000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ vdd_3v3: buck1 {
+ regulator-name = "VDD_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ vdd_1v8_ldo0: ldo0 {
+ regulator-name = "VDD_1V8_LDO0";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ vdda_1v8: ldo1 {
+ regulator-name = "VDDA_1V8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+ };
};
&main_r5fss0_core0 {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema
2024-04-29 19:58 [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema Nathan Morrisson
2024-04-29 19:58 ` [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC Nathan Morrisson
@ 2024-04-30 7:44 ` Krzysztof Kozlowski
2024-05-02 17:24 ` (subset) " Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-30 7:44 UTC (permalink / raw
To: Nathan Morrisson, lee, robh, krzk+dt, conor+dt, nm, vigneshr,
kristo, j-keerthy
Cc: devicetree, linux-kernel, linux-arm-kernel, upstream, w.egorov
On 29/04/2024 21:58, Nathan Morrisson wrote:
> Convert the lp873x binding to DT schema format. The gpio-controller
> and #gpio-cells properties were removed from required because using
> the device as a GPIO controller is optional.
>
> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC
2024-04-29 19:58 ` [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC Nathan Morrisson
@ 2024-05-02 7:25 ` Wadim Egorov
2024-06-13 8:57 ` (subset)[PATCH " Vignesh Raghavendra
1 sibling, 0 replies; 6+ messages in thread
From: Wadim Egorov @ 2024-05-02 7:25 UTC (permalink / raw
To: Nathan Morrisson, lee, robh, krzk+dt, conor+dt, nm, vigneshr,
kristo, j-keerthy
Cc: devicetree, linux-kernel, linux-arm-kernel, upstream
Hi,
Am 29.04.24 um 21:58 schrieb Nathan Morrisson:
> Add a PMIC node to the phycore-am64 device tree.
>
> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
Reviewed-by: Wadim Egorov <w.egorov@phytec.de>
Please enable the PMIC driver in the arm64 defconfig.
REGULATOR_LP873X & CONFIG_MFD_TI_LP873X
> ---
> v2: No change
>
> .../boot/dts/ti/k3-am64-phycore-som.dtsi | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> index 125e507966fb..2c3b20ddfb8b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> @@ -265,6 +265,50 @@ i2c_som_rtc: rtc@52 {
> interrupts = <70 IRQ_TYPE_EDGE_FALLING>;
> wakeup-source;
> };
> +
> + pmic@61 {
> + compatible = "ti,lp8733";
> + reg = <0x61>;
> +
> + buck0-in-supply = <&vcc_5v0_som>;
> + buck1-in-supply = <&vcc_5v0_som>;
> + ldo0-in-supply = <&vdd_3v3>;
> + ldo1-in-supply = <&vdd_3v3>;
> +
> + regulators {
> + vdd_core: buck0 {
> + regulator-name = "VDD_CORE";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <750000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vdd_3v3: buck1 {
> + regulator-name = "VDD_3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vdd_1v8_ldo0: ldo0 {
> + regulator-name = "VDD_1V8_LDO0";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vdda_1v8: ldo1 {
> + regulator-name = "VDDA_1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> + };
> + };
> };
>
> &main_r5fss0_core0 {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema
2024-04-29 19:58 [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema Nathan Morrisson
2024-04-29 19:58 ` [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC Nathan Morrisson
2024-04-30 7:44 ` [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema Krzysztof Kozlowski
@ 2024-05-02 17:24 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2024-05-02 17:24 UTC (permalink / raw
To: lee, robh, krzk+dt, conor+dt, nm, vigneshr, kristo, j-keerthy,
Nathan Morrisson
Cc: devicetree, linux-kernel, linux-arm-kernel, upstream, w.egorov
On Mon, 29 Apr 2024 12:58:29 -0700, Nathan Morrisson wrote:
> Convert the lp873x binding to DT schema format. The gpio-controller
> and #gpio-cells properties were removed from required because using
> the device as a GPIO controller is optional.
>
>
Applied, thanks!
[1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema
commit: 7fcb2977c0b55c2d11aea3a6baa4c59d53709041
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset)[PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC
2024-04-29 19:58 ` [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC Nathan Morrisson
2024-05-02 7:25 ` Wadim Egorov
@ 2024-06-13 8:57 ` Vignesh Raghavendra
1 sibling, 0 replies; 6+ messages in thread
From: Vignesh Raghavendra @ 2024-06-13 8:57 UTC (permalink / raw
To: Nathan Morrisson, lee, robh, krzk+dt, conor+dt, nm, kristo,
j-keerthy
Cc: devicetree, linux-kernel, linux-arm-kernel, upstream, w.egorov
Hi Nathan,
On 30/04/24 01:28, Nathan Morrisson wrote:
> Add a PMIC node to the phycore-am64 device tree.
>
> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
> ---
> v2: No change
>
> .../boot/dts/ti/k3-am64-phycore-som.dtsi | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[2/2] arm64: dts: ti: phycore-am64: Add PMIC
commit: f3841b6a22f1a7635dc73b94b98596b94d153ed1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-13 8:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 19:58 [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema Nathan Morrisson
2024-04-29 19:58 ` [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC Nathan Morrisson
2024-05-02 7:25 ` Wadim Egorov
2024-06-13 8:57 ` (subset)[PATCH " Vignesh Raghavendra
2024-04-30 7:44 ` [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema Krzysztof Kozlowski
2024-05-02 17:24 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).