From: Stephen Boyd <swboyd@chromium.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Douglas Anderson <dianders@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Puranjay Mohan <puranjay@kernel.org>,
Sumit Garg <sumit.garg@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: puranjay12@gmail.com
Subject: Re: [PATCH v3 2/2] arm64: implement raw_smp_processor_id() using thread_info
Date: Wed, 8 May 2024 14:13:26 -0700 [thread overview]
Message-ID: <CAE-0n5248NiYQ9KvLqwaLuSSGXMM4RMtnB2uayZQbdJXQWTAvw@mail.gmail.com> (raw)
In-Reply-To: <20240503171847.68267-2-puranjay@kernel.org>
Quoting Puranjay Mohan (2024-05-03 10:18:47)
> Remove the percpu variable cpu_number as it is used only in
> set_smp_ipi_range() as a dummy variable to be passed to ipi_handler().
> Use irq_stat in place of cpu_number here like arm32.
>
> [1] https://github.com/puranjaymohan/linux/commit/77d3fdd
Maybe you should have put this under the cut for the patch so its on
the mailing list, and lore.
>
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 4ced34f62dab..98d4e352c3d0 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -1021,12 +1016,12 @@ void __init set_smp_ipi_range(int ipi_base, int n)
>
> if (ipi_should_be_nmi(i)) {
> err = request_percpu_nmi(ipi_base + i, ipi_handler,
> - "IPI", &cpu_number);
> + "IPI", &irq_stat);
I know this is mirroring arm, but it would be nice to have a comment
saying that we need some percpu variable here even if the handler
doesn't use it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-08 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 17:18 [PATCH v3 1/2] arm64/arch_timer: include <linux/percpu.h> Puranjay Mohan
2024-05-03 17:18 ` [PATCH v3 2/2] arm64: implement raw_smp_processor_id() using thread_info Puranjay Mohan
2024-05-08 21:13 ` Stephen Boyd [this message]
2024-05-08 21:10 ` [PATCH v3 1/2] arm64/arch_timer: include <linux/percpu.h> Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n5248NiYQ9KvLqwaLuSSGXMM4RMtnB2uayZQbdJXQWTAvw@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=puranjay12@gmail.com \
--cc=puranjay@kernel.org \
--cc=sumit.garg@linaro.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).