From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Praveenkumar I <quic_ipkumar@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, gregkh@linuxfoundation.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
geert+renesas@glider.be, arnd@arndb.de,
neil.armstrong@linaro.org, nfraprado@collabora.com,
u-kumar1@ti.com, peng.fan@nxp.com, quic_wcheng@quicinc.com,
quic_varada@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: quic_kathirav@quicinc.com, quic_nsekar@quicinc.com,
quic_srichara@quicinc.com
Subject: Re: [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node
Date: Sat, 30 Sep 2023 20:27:33 +0300 [thread overview]
Message-ID: <cc6e2145-ee6f-4872-9c47-8f618b47dc27@linaro.org> (raw)
In-Reply-To: <20230929084209.3033093-7-quic_ipkumar@quicinc.com>
On 29/09/2023 11:42, Praveenkumar I wrote:
> Add UNIPHY node in USB to support Super-speed. As the SS PHY has
> pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 1813b9fa4bb5..8fe4e45bfc18 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -349,8 +349,6 @@ usb: usb@8af8800 {
>
> resets = <&gcc GCC_USB_BCR>;
>
> - qcom,select-utmi-as-pipe-clk;
> -
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
> @@ -363,8 +361,8 @@ usb_dwc: usb@8a00000 {
> clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>;
> clock-names = "ref";
> interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
> - phy-names = "usb2-phy";
> - phys = <&usbphy0>;
> + phy-names = "usb2-phy", "usb3-phy";
> + phys = <&usbphy0>, <&usbphy1>;
Ah, I see now. Maybe usbphy_ss_0 or something like that would be a
better label for this PHY. I'd expect usbphy1 to be used for other host
than usbphy0.
> tx-fifo-resize;
> snps,is-utmi-l1-suspend;
> snps,hird-threshold = /bits/ 8 <0x0>;
--
With best wishes
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-30 17:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:42 [PATCH 0/8] Enable USB3 for Qualcomm IPQ5332 Praveenkumar I
2023-09-29 8:42 ` [PATCH 1/8] dt-bindings: phy: qcom,uniphy-usb: Document qcom,uniphy-usb phy Praveenkumar I
2023-09-30 14:56 ` Krzysztof Kozlowski
2023-10-03 14:09 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 2/8] phy: qcom: Introduce Super-Speed USB UNIPHY driver Praveenkumar I
2023-09-30 17:18 ` Dmitry Baryshkov
2023-10-03 14:21 ` Praveenkumar I
2023-10-03 14:54 ` Dmitry Baryshkov
2023-10-03 16:33 ` Praveenkumar I
2023-10-06 23:57 ` Konrad Dybcio
2023-10-09 12:22 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 3/8] arm64: dts: qcom: ipq5332: Add USB Super-Speed PHY node Praveenkumar I
2023-09-29 12:56 ` Konrad Dybcio
2023-09-29 13:30 ` Praveenkumar I
2023-09-30 17:22 ` Dmitry Baryshkov
2023-10-03 14:28 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 4/8] dt-bindings: usb: dwc3: Add clocks on Qualcomm IPQ5332 Praveenkumar I
2023-09-30 14:58 ` Krzysztof Kozlowski
2023-09-30 17:23 ` Dmitry Baryshkov
2023-10-03 14:30 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 5/8] arm64: dts: qcom: ipq5332: Add clocks for USB Super-Speed Praveenkumar I
2023-09-30 17:25 ` Dmitry Baryshkov
2023-10-03 14:42 ` Praveenkumar I
2023-10-03 14:45 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node Praveenkumar I
2023-09-29 13:14 ` Konrad Dybcio
2023-09-29 13:31 ` Praveenkumar I
2023-09-30 17:26 ` Dmitry Baryshkov
2023-10-03 14:02 ` Praveenkumar I
2023-09-30 17:27 ` Dmitry Baryshkov [this message]
2023-10-03 14:42 ` Praveenkumar I
2023-09-29 8:42 ` [PATCH 7/8] arm64: dts: qcom: ipq5332: Enable USB Super-Speed PHY Praveenkumar I
2023-09-29 8:42 ` [PATCH 8/8] arm64: defconfig: Enable qcom USB UNIPHY driver Praveenkumar I
2023-09-30 14:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc6e2145-ee6f-4872-9c47-8f618b47dc27@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).