From: Bartosz Golaszewski <brgl@bgdev.pl>
To: neil.armstrong@linaro.org
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Tengfei Fan <quic_tengfan@quicinc.com>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Alex Elder <elder@kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document the SA8775p ADSP, CDSP and GPDSP
Date: Wed, 22 May 2024 15:08:49 +0200 [thread overview]
Message-ID: <CAMRc=Mcd4qoF-BtHdpHSy5DEDDKYV7RK2hCgegf7_63eRoahTQ@mail.gmail.com> (raw)
In-Reply-To: <42ba8472-9d63-4125-b538-39d8090203b4@linaro.org>
On Wed, May 22, 2024 at 3:06 PM <neil.armstrong@linaro.org> wrote:
>
> On 22/05/2024 15:04, Bartosz Golaszewski wrote:
> > On Wed, May 22, 2024 at 2:42 PM <neil.armstrong@linaro.org> wrote:
> >>
> >> On 22/05/2024 14:08, Bartosz Golaszewski wrote:
> >>> From: Tengfei Fan <quic_tengfan@quicinc.com>
> >>>
> >>> Document the compatibles for the components used to boot the ADSP, CDSP0,
> >>> CDSP1, GPDSP0 and GPDSP1 on the SA8775p SoC.
> >>>
> >>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> >>> Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >>> ---
> >>> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 76 +++++++++++++++++++++-
> >>> 1 file changed, 75 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> >>> index 73fda7565cd1..9d3a862c39e1 100644
> >>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> >>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> >>> @@ -16,6 +16,11 @@ description:
> >>> properties:
> >>> compatible:
> >>> enum:
> >>> + - qcom,sa8775p-adsp-pas
> >>> + - qcom,sa8775p-cdsp0-pas
> >>> + - qcom,sa8775p-cdsp1-pas
> >>> + - qcom,sa8775p-gpdsp0-pas
> >>> + - qcom,sa8775p-gpdsp1-pas
> >>> - qcom,sm8550-adsp-pas
> >>> - qcom,sm8550-cdsp-pas
> >>> - qcom,sm8550-mpss-pas
> >>> @@ -44,12 +49,13 @@ properties:
> >>>
> >>> firmware-name:
> >>> $ref: /schemas/types.yaml#/definitions/string-array
> >>> + minItems: 1
> >>
> >> This will allow a single firmware name for all compatible,
> >> which is wrong
> >>
> >
> > So increasing the limit from the default under allOf doesn't seem to
> > work, should I instead keep this and make the lower limit stricter for
> > all other models?
>
> Yes add minItems in all the allOf:if: and add the missing allOf:if: for
> the new compatibles to set the minItems, same for memory-region.
>
> Or you may simply spin off a new yaml, this one is getting quite large.
>
Yeah, maybe that's a better idea.
Bart
> Neil
>
> >
> > Bart
> >
> >>> items:
> >>> - description: Firmware name of the Hexagon core
> >>> - description: Firmware name of the Hexagon Devicetree
> >>>
> >>> memory-region:
> >>> - minItems: 2
> >>> + minItems: 1
> >>
> >> Same here
> >>
> >>> items:
> >>> - description: Memory region for main Firmware authentication
> >>> - description: Memory region for Devicetree Firmware authentication
> >>> @@ -81,6 +87,21 @@ allOf:
> >>> maxItems: 5
> >>> memory-region:
> >>> maxItems: 2
> >>> + - if:
> >>> + properties:
> >>> + compatible:
> >>> + enum:
> >>> + - qcom,sa8775p-adsp-pas
> >>> + - qcom,sa8775p-cdsp0-pas
> >>> + - qcom,sa8775p-cdsp1-pas
> >>> + - qcom,sa8775p-gpdsp0-pas
> >>> + - qcom,sa8775p-gpdsp1-pas
> >>> + then:
> >>> + properties:
> >>> + interrupts:
> >>> + maxItems: 5
> >>> + interrupt-names:
> >>> + maxItems: 5
> >>> - if:
> >>> properties:
> >>> compatible:
> >>> @@ -128,6 +149,7 @@ allOf:
> >>> properties:
> >>> compatible:
> >>> enum:
> >>> + - qcom,sa8775p-adsp-pas
> >>> - qcom,sm8550-adsp-pas
> >>> - qcom,sm8650-adsp-pas
> >>> - qcom,x1e80100-adsp-pas
> >>> @@ -177,6 +199,58 @@ allOf:
> >>> - const: cx
> >>> - const: mxc
> >>> - const: nsp
> >>> + - if:
> >>> + properties:
> >>> + compatible:
> >>> + enum:
> >>> + - qcom,sa8775p-cdsp-pas
> >>> + then:
> >>> + properties:
> >>> + power-domains:
> >>> + items:
> >>> + - description: CX power domain
> >>> + - description: MXC power domain
> >>> + - description: NSP0 power domain
> >>> + power-domain-names:
> >>> + items:
> >>> + - const: cx
> >>> + - const: mxc
> >>> + - const: nsp0
> >>> +
> >>> + - if:
> >>> + properties:
> >>> + compatible:
> >>> + enum:
> >>> + - qcom,sa8775p-cdsp1-pas
> >>> + then:
> >>> + properties:
> >>> + power-domains:
> >>> + items:
> >>> + - description: CX power domain
> >>> + - description: MXC power domain
> >>> + - description: NSP1 power domain
> >>> + power-domain-names:
> >>> + items:
> >>> + - const: cx
> >>> + - const: mxc
> >>> + - const: nsp1
> >>> +
> >>> + - if:
> >>> + properties:
> >>> + compatible:
> >>> + enum:
> >>> + - qcom,sa8775p-gpdsp0-pas
> >>> + - qcom,sa8775p-gpdsp1-pas
> >>> + then:
> >>> + properties:
> >>> + power-domains:
> >>> + items:
> >>> + - description: CX power domain
> >>> + - description: MXC power domain
> >>> + power-domain-names:
> >>> + items:
> >>> + - const: cx
> >>> + - const: mxc
> >>>
> >>> unevaluatedProperties: false
> >>>
> >>>
> >>
>
next prev parent reply other threads:[~2024-05-22 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 12:08 [PATCH 0/5] arm64: qcom: sa8775p: enable remoteprocs - ADSP, CDSP and GPDSP Bartosz Golaszewski
2024-05-22 12:08 ` [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document the SA8775p " Bartosz Golaszewski
2024-05-22 12:42 ` neil.armstrong
2024-05-22 13:04 ` Bartosz Golaszewski
2024-05-22 13:06 ` neil.armstrong
2024-05-22 13:08 ` Bartosz Golaszewski [this message]
2024-05-29 14:31 ` Konrad Dybcio
2024-05-22 12:08 ` [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Add GPDSP0 and GPDSP1 clients Bartosz Golaszewski
2024-05-22 14:21 ` Krzysztof Kozlowski
2024-05-22 12:08 ` [PATCH 3/5] remoteproc: qcom_q6v5_pas: Add support for SA8775p ADSP, CDSP and GPDSP Bartosz Golaszewski
2024-05-22 12:08 ` [PATCH 4/5] arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes Bartosz Golaszewski
2024-05-22 12:08 ` [PATCH 5/5] arm64: dts: qcom: sa8775p-ride: enable remoteprocs Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Mcd4qoF-BtHdpHSy5DEDDKYV7RK2hCgegf7_63eRoahTQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_tengfan@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).