Linux-ARM-MSM Archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node
@ 2024-04-16 10:50 Viken Dadhaniya
  2024-04-16 12:32 ` Dmitry Baryshkov
  0 siblings, 1 reply; 4+ messages in thread
From: Viken Dadhaniya @ 2024-04-16 10:50 UTC (permalink / raw
  To: andersson, konrad.dybcio, robh, krzk+dt, linux-arm-msm, conor+dt,
	devicetree, linux-kernel
  Cc: quic_msavaliy, quic_anupkulk, Viken Dadhaniya

Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
busses usecase on RB3 platform.

Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index c98c41f8f3b1..811033592bab 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -603,10 +603,22 @@
 	status = "okay";
 };
 
+&gpi_dma0 {
+	status = "okay";
+};
+
+&gpi_dma1 {
+	status = "okay";
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };
 
+&qupv3_id_1 {
+	status = "okay";
+};
+
 &remoteproc_adsp {
 	firmware-name = "qcom/qcs6490/adsp.mbn";
 	status = "okay";
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node
  2024-04-16 10:50 [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node Viken Dadhaniya
@ 2024-04-16 12:32 ` Dmitry Baryshkov
  2024-04-16 12:34   ` Dmitry Baryshkov
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-04-16 12:32 UTC (permalink / raw
  To: Viken Dadhaniya
  Cc: andersson, konrad.dybcio, robh, krzk+dt, linux-arm-msm, conor+dt,
	devicetree, linux-kernel, quic_msavaliy, quic_anupkulk

On Tue, 16 Apr 2024 at 13:51, Viken Dadhaniya <quic_vdadhani@quicinc.com> wrote:
>
> Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
> busses usecase on RB3 platform.
>
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node
  2024-04-16 12:32 ` Dmitry Baryshkov
@ 2024-04-16 12:34   ` Dmitry Baryshkov
  2024-04-24  5:51     ` Viken Dadhaniya
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-04-16 12:34 UTC (permalink / raw
  To: Viken Dadhaniya
  Cc: andersson, konrad.dybcio, robh, krzk+dt, linux-arm-msm, conor+dt,
	devicetree, linux-kernel, quic_msavaliy, quic_anupkulk

On Tue, 16 Apr 2024 at 15:32, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Tue, 16 Apr 2024 at 13:51, Viken Dadhaniya <quic_vdadhani@quicinc.com> wrote:
> >
> > Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
> > busses usecase on RB3 platform.
> >
> > Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> > ---
> >  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Well, actually:

Unreviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Please place the gpi_dmaN nodes where they belong rather than sticking
them right before the qup nodes. The file should be sorted.

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node
  2024-04-16 12:34   ` Dmitry Baryshkov
@ 2024-04-24  5:51     ` Viken Dadhaniya
  0 siblings, 0 replies; 4+ messages in thread
From: Viken Dadhaniya @ 2024-04-24  5:51 UTC (permalink / raw
  To: Dmitry Baryshkov
  Cc: andersson, konrad.dybcio, robh, krzk+dt, linux-arm-msm, conor+dt,
	devicetree, linux-kernel, quic_msavaliy, quic_anupkulk



On 4/16/2024 6:04 PM, Dmitry Baryshkov wrote:
> On Tue, 16 Apr 2024 at 15:32, Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
>>
>> On Tue, 16 Apr 2024 at 13:51, Viken Dadhaniya <quic_vdadhani@quicinc.com> wrote:
>>>
>>> Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
>>> busses usecase on RB3 platform.
>>>
>>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
>>>   1 file changed, 12 insertions(+)
>>
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Well, actually:
> 
> Unreviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> Please place the gpi_dmaN nodes where they belong rather than sticking
> them right before the qup nodes. The file should be sorted.
> 

Updated in v2.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-24  5:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-16 10:50 [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node Viken Dadhaniya
2024-04-16 12:32 ` Dmitry Baryshkov
2024-04-16 12:34   ` Dmitry Baryshkov
2024-04-24  5:51     ` Viken Dadhaniya

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).