From: Coly Li <colyli@suse.de>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org
Subject: Re: [PATCH 2/3] bcache: Convert to lib/time_stats
Date: Thu, 1 Sep 2022 10:19:59 +0800 [thread overview]
Message-ID: <20DDF7B2-8433-49EE-8F9F-CB335D2E7B6C@suse.de> (raw)
In-Reply-To: <20220831173639.sb6bhg5xvn4gbkiu@moria.home.lan>
> 2022年9月1日 01:36，Kent Overstreet <kent.overstreet@linux.dev> 写道：
>
> On Thu, Sep 01, 2022 at 01:02:37AM +0800, Coly Li wrote:
>> Can I understand that rate = 1/frequency ? Then frequency 4 is around to rate 0.
>
> Correct, rate = 1/frequency.
>
>>> The quantiles are for the duration, they give you an idea of the statistical
>>> distribution, see https://en.wikipedia.org/wiki/Quantile
>>
>> I wanted to ask how to read the quantiles line. Does it mean that 1 ns is
>> equally divided by 15 segments, and the counter values are for the divided
>> 1/15 ns segments?
>
> It is the 15 boundaries between 16 equal segments, yes.
>
>> Quantiles are much humane, standard deviation is scared… Just FYI LOL.
>
> That's valuable feedback then, maybe we'll keep both. The more expensive part of
> time stats is just ingesting data points, but we've got a percpu buffer frontend
> for that - just doing a bit more moth doesn't cost much.
I don’t have more question so far. Thanks for the detailed replay.
Coly Li
next prev parent reply other threads:[~2022-09-01 2:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 16:53 Time stats library (from bcache/bcachefs) & generic latency instrumentation Kent Overstreet
2022-08-29 16:53 ` [PATCH 1/3] lib/time_stats: New library for statistics on events Kent Overstreet
2022-08-29 23:34 ` Randy Dunlap
2022-08-30 0:00 ` Kent Overstreet
2022-08-29 16:53 ` [PATCH 2/3] bcache: Convert to lib/time_stats Kent Overstreet
2022-08-31 16:00 ` Coly Li
2022-08-31 16:54 ` Kent Overstreet
2022-08-31 17:02 ` Coly Li
2022-08-31 17:36 ` Kent Overstreet
2022-09-01 2:19 ` Coly Li [this message]
2022-08-29 16:53 ` [PATCH 3/3] Code tagging based latency tracking Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20DDF7B2-8433-49EE-8F9F-CB335D2E7B6C@suse.de \
--to=colyli@suse.de \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).