From: Roman Gushchin <roman.gushchin@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>,
kernel test robot <lkp@intel.com>
Cc: virtualization@lists.linux-foundation.org,
usbb2k-api-dev@nongnu.org, tipc-discussion@lists.sourceforge.net,
target-devel@vger.kernel.org,
sound-open-firmware@alsa-project.org,
samba-technical@lists.samba.org, rds-devel@oss.oracle.com,
patches@opensource.cirrus.com,
osmocom-net-gprs@lists.osmocom.org,
openipmi-developer@lists.sourceforge.net, nvdimm@lists.linux.dev,
ntb@lists.linux.dev, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, mjpeg-users@lists.sourceforge.net,
megaraidlinux.pdl@broadcom.com, linuxppc-dev@lists.ozlabs.org,
linux1394-devel@lists.sourceforge.net, linux-x25@vger.kernel.org,
linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-usb@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-staging@lists.linux.dev, linux-serial@vger.kernel.org,
linux-sctp@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-raid@vger.kernel.org, linux-pm@vger.kernel.org,
linux-phy@lists.infradead.org, linux-perf-users@vger.kernel.org,
linux-pci@vger.kernel.org, linux-parport@lists.infradead.org,
linux-parisc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-nfc@lists.01.org, linux-mtd@lists.infradead.org,
linux-mmc@vger.kernel.org, linux-mm@kvack.org,
linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
linux-leds@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-ide@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-fpga@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-efi@vger.kernel.org, linux-cxl@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-clk@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-block@vger.kernel.org,
linux-bcache@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linaro-mm-sig@lists.linaro.org,
legousb-devel@lists.sourceforge.net, kvm@vger.kernel.org,
keyrings@vger.kernel.org, isdn4linux@listserv.isdn4linux.de,
iommu@lists.linux.dev, iommu@lists.linux-foundation.org,
intel-wired-lan@lists.osuosl.org,
dri-devel@lists.freedesktop.org, dm-devel@redhat.com,
devicetree@vger.kernel.org, dev@openvswitch.org,
dccp@vger.kernel.org, damon@lists.linux.dev,
coreteam@netfilter.org, cgroups@vger.kernel.org,
ceph-devel@vger.kernel.org, apparmor@lists.ubuntu.com,
amd-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org,
accessrunner-general@lists.sourceforge.net
Subject: Re: [linux-next:master] BUILD REGRESSION 6cc11d2a1759275b856e464265823d94aabd5eaf
Date: Fri, 1 Jul 2022 18:03:10 -0700 [thread overview]
Message-ID: <Yr+ZTnLb9lJk6fJO@castle> (raw)
In-Reply-To: <62be3696.+PAAAVlbtWK6G2hk%lkp@intel.com>
esOn Fri, Jul 01, 2022 at 07:49:42AM +0800, kbuild test robot wrote:
> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> branch HEAD: 6cc11d2a1759275b856e464265823d94aabd5eaf Add linux-next specific files for 20220630
>
> Error/Warning reports:
>
> https://lore.kernel.org/linux-mm/202206301859.UodBCrva-lkp@intel.com
>
> Error/Warning: (recently discovered and may have been fixed)
>
> arch/powerpc/kernel/interrupt.c:542:55: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> arch/powerpc/kernel/interrupt.c:542:55: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
> drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning: no previous prototype for 'pci_read' [-Wmissing-prototypes]
> drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning: no previous prototype for 'pci_write' [-Wmissing-prototypes]
> mm/shrinker_debug.c:143:9: warning: function 'shrinker_debugfs_rename' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> mm/shrinker_debug.c:217:9: warning: function 'shrinker_debugfs_rename' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> mm/vmscan.c:637:9: warning: function 'prealloc_shrinker' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> mm/vmscan.c:642:9: warning: function 'prealloc_shrinker' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> mm/vmscan.c:697:9: warning: function 'register_shrinker' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> mm/vmscan.c:702:9: warning: function 'register_shrinker' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
Shrinker-related warnings should be fixed by the following patch.
Thanks!
--
From c399aff65c7745a209397a531c5b28fd404d83c2 Mon Sep 17 00:00:00 2001
From: Roman Gushchin <roman.gushchin@linux.dev>
Date: Fri, 1 Jul 2022 17:38:31 -0700
Subject: [PATCH] mm:shrinkers: fix build warnings
Add __printf(a, b) attributes to shrinker functions taking shrinker
name as an argument to avoid compiler warnings like:
mm/shrinker_debug.c:143:9: warning: function 'shrinker_debugfs_rename'
might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
mm/shrinker_debug.c:217:9: warning: function 'shrinker_debugfs_rename'
might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
mm/vmscan.c:637:9: warning: function 'prealloc_shrinker' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
mm/vmscan.c:642:9: warning: function 'prealloc_shrinker' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
mm/vmscan.c:697:9: warning: function 'register_shrinker' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
mm/vmscan.c:702:9: warning: function 'register_shrinker' might be a
candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
---
include/linux/shrinker.h | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h
index 64416f3e0a1f..08e6054e061f 100644
--- a/include/linux/shrinker.h
+++ b/include/linux/shrinker.h
@@ -93,9 +93,11 @@ struct shrinker {
*/
#define SHRINKER_NONSLAB (1 << 3)
-extern int prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...);
+extern int __printf(2, 3) prealloc_shrinker(struct shrinker *shrinker,
+ const char *fmt, ...);
extern void register_shrinker_prepared(struct shrinker *shrinker);
-extern int register_shrinker(struct shrinker *shrinker, const char *fmt, ...);
+extern int __printf(2, 3) register_shrinker(struct shrinker *shrinker,
+ const char *fmt, ...);
extern void unregister_shrinker(struct shrinker *shrinker);
extern void free_prealloced_shrinker(struct shrinker *shrinker);
extern void synchronize_shrinkers(void);
@@ -103,8 +105,8 @@ extern void synchronize_shrinkers(void);
#ifdef CONFIG_SHRINKER_DEBUG
extern int shrinker_debugfs_add(struct shrinker *shrinker);
extern void shrinker_debugfs_remove(struct shrinker *shrinker);
-extern int shrinker_debugfs_rename(struct shrinker *shrinker,
- const char *fmt, ...);
+extern int __printf(2, 3) shrinker_debugfs_rename(struct shrinker *shrinker,
+ const char *fmt, ...);
#else /* CONFIG_SHRINKER_DEBUG */
static inline int shrinker_debugfs_add(struct shrinker *shrinker)
{
@@ -113,8 +115,8 @@ static inline int shrinker_debugfs_add(struct shrinker *shrinker)
static inline void shrinker_debugfs_remove(struct shrinker *shrinker)
{
}
-static inline int shrinker_debugfs_rename(struct shrinker *shrinker,
- const char *fmt, ...)
+static inline __printf(2, 3)
+int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...)
{
return 0;
}
--
2.36.1
parent reply other threads:[~2022-07-02 1:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <62be3696.+PAAAVlbtWK6G2hk%lkp@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr+ZTnLb9lJk6fJO@castle \
--to=roman.gushchin@linux.dev \
--cc=accessrunner-general@lists.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apparmor@lists.ubuntu.com \
--cc=ceph-devel@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=damon@lists.linux.dev \
--cc=dccp@vger.kernel.org \
--cc=dev@openvswitch.org \
--cc=devicetree@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=keyrings@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=legousb-devel@lists.sourceforge.net \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=mjpeg-users@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ntb@lists.linux.dev \
--cc=nvdimm@lists.linux.dev \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=patches@opensource.cirrus.com \
--cc=rds-devel@oss.oracle.com \
--cc=samba-technical@lists.samba.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=target-devel@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=usbb2k-api-dev@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).