From: Bart Van Assche <bvanassche@acm.org>
To: mwilck@suse.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 3/3] scsi: simplify scsi_stop_queue()
Date: Sun, 4 Jun 2023 06:54:45 -0700 [thread overview]
Message-ID: <59a03648-f65f-0c7c-b200-1b24f321c2d6@acm.org> (raw)
In-Reply-To: <20230602163845.32108-4-mwilck@suse.com>
On 6/2/23 09:38, mwilck@suse.com wrote:
> @@ -2910,6 +2904,13 @@ scsi_target_block(struct device *dev)
> device_block);
> else
> device_for_each_child(dev, NULL, target_block);
> +
> + /*
> + * SCSI never enables blk-mq's BLK_MQ_F_BLOCKING flag,
> + * so blk_mq_wait_quiesce_done() comes down to just synchronize_rcu().
> + * Just calling it once is enough.
> + */
> + synchronize_rcu();
> }
> EXPORT_SYMBOL_GPL(scsi_target_block);
The above comment is wrong. See also commit b125bb99559e ("scsi:
core: Support setting BLK_MQ_F_BLOCKING").
Bart.
next prev parent reply other threads:[~2023-06-04 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 16:38 [PATCH 0/3] scsi: fixes for targets with many LUNs mwilck
2023-06-02 16:38 ` [PATCH 1/3] bsg: increase number of devices mwilck
2023-06-02 16:38 ` [PATCH 2/3] scsi: sg: " mwilck
2023-06-04 1:45 ` Douglas Gilbert
2023-06-02 16:38 ` [PATCH 3/3] scsi: simplify scsi_stop_queue() mwilck
2023-06-04 13:54 ` Bart Van Assche [this message]
2023-06-05 7:31 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59a03648-f65f-0c7c-b200-1b24f321c2d6@acm.org \
--to=bvanassche@acm.org \
--cc=Bart.VanAssche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).