From: Douglas Gilbert <dgilbert@interlog.com>
To: mwilck@suse.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 2/3] scsi: sg: increase number of devices
Date: Sat, 3 Jun 2023 21:45:15 -0400 [thread overview]
Message-ID: <b99938ff-d08f-63c2-b146-8c4e6488038b@interlog.com> (raw)
In-Reply-To: <20230602163845.32108-3-mwilck@suse.com>
On 2023-06-02 12:38, mwilck@suse.com wrote:
> From: Hannes Reinecke <hare@suse.de>
>
> Larger setups may need to allocate more than 32k sg devices, so
> increase the number of devices to the full range of minor device
> numbers.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Thanks.
> ---
> drivers/scsi/sg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 037f8c98a6d3..6c04cf941dac 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -71,7 +71,7 @@ static int sg_proc_init(void);
>
> #define SG_ALLOW_DIO_DEF 0
>
> -#define SG_MAX_DEVS 32768
> +#define SG_MAX_DEVS (1 << MINORBITS)
>
> /* SG_MAX_CDB_SIZE should be 260 (spc4r37 section 3.1.30) however the type
> * of sg_io_hdr::cmd_len can only represent 255. All SCSI commands greater
next prev parent reply other threads:[~2023-06-04 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 16:38 [PATCH 0/3] scsi: fixes for targets with many LUNs mwilck
2023-06-02 16:38 ` [PATCH 1/3] bsg: increase number of devices mwilck
2023-06-02 16:38 ` [PATCH 2/3] scsi: sg: " mwilck
2023-06-04 1:45 ` Douglas Gilbert [this message]
2023-06-02 16:38 ` [PATCH 3/3] scsi: simplify scsi_stop_queue() mwilck
2023-06-04 13:54 ` Bart Van Assche
2023-06-05 7:31 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b99938ff-d08f-63c2-b146-8c4e6488038b@interlog.com \
--to=dgilbert@interlog.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).