From: Pauli Virtanen <pav@iki.fi>
To: linux-bluetooth@vger.kernel.org
Cc: Pauli Virtanen <pav@iki.fi>
Subject: [PATCH BlueZ] tools: fix using too small buffers in test-runner
Date: Sat, 11 May 2024 13:32:07 +0300 [thread overview]
Message-ID: <9b7b8130a4296de7e02435d7be3c6d00c4976427.1715423446.git.pav@iki.fi> (raw)
Fix compiler warning:
tools/test-runner.c:309:57: error: 'sprintf' may write a terminating nul
past the end of the destination [-Werror=format-overflow=]
---
tools/test-runner.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/test-runner.c b/tools/test-runner.c
index 243eab468..5bdcf42fc 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -302,10 +302,10 @@ static void start_qemu(void)
const char *path = "/tmp/bt-server-bredr";
char *chrdev, *serdev;
- chrdev = alloca(32 + strlen(path));
+ chrdev = alloca(48 + strlen(path));
sprintf(chrdev, "socket,path=%s,id=bt%d", path, i);
- serdev = alloca(32);
+ serdev = alloca(48);
sprintf(serdev, "pci-serial,chardev=bt%d", i);
argv[pos++] = "-chardev";
--
2.45.0
next reply other threads:[~2024-05-11 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 10:32 Pauli Virtanen [this message]
2024-05-11 11:59 ` [BlueZ] tools: fix using too small buffers in test-runner bluez.test.bot
2024-05-13 14:10 ` [PATCH BlueZ] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b7b8130a4296de7e02435d7be3c6d00c4976427.1715423446.git.pav@iki.fi \
--to=pav@iki.fi \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).