* [PATCH v2] btrfs: remove unused inode argument from uncompress_inline()
@ 2015-05-19 14:46 Byongho Lee
2015-05-21 14:45 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Byongho Lee @ 2015-05-19 14:46 UTC (permalink / raw
To: linux-btrfs
The inode argument is never used from the beginning, so remove it.
Change since v1:
- Add missing Signed-off-by line.
Signed-off-by: Byongho Lee <bhlee.kernel@gmail.com>
---
fs/btrfs/inode.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 0020b56..6abd9ae 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6565,7 +6565,7 @@ static int merge_extent_mapping(struct extent_map_tree *em_tree,
}
static noinline int uncompress_inline(struct btrfs_path *path,
- struct inode *inode, struct page *page,
+ struct page *page,
size_t pg_offset, u64 extent_offset,
struct btrfs_file_extent_item *item)
{
@@ -6761,8 +6761,7 @@ next:
if (create == 0 && !PageUptodate(page)) {
if (btrfs_file_extent_compression(leaf, item) !=
BTRFS_COMPRESS_NONE) {
- ret = uncompress_inline(path, inode, page,
- pg_offset,
+ ret = uncompress_inline(path, page, pg_offset,
extent_offset, item);
if (ret) {
err = ret;
--
2.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] btrfs: remove unused inode argument from uncompress_inline()
2015-05-19 14:46 [PATCH v2] btrfs: remove unused inode argument from uncompress_inline() Byongho Lee
@ 2015-05-21 14:45 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2015-05-21 14:45 UTC (permalink / raw
To: Byongho Lee; +Cc: linux-btrfs
On Tue, May 19, 2015 at 11:46:45PM +0900, Byongho Lee wrote:
> The inode argument is never used from the beginning, so remove it.
>
> Change since v1:
> - Add missing Signed-off-by line.
This ^^^ belongs ...
>
> Signed-off-by: Byongho Lee <bhlee.kernel@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
> ---
... here. The text below --- will not be part of the commit changelog,
and is meant to be read by other people.
> fs/btrfs/inode.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-21 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 14:46 [PATCH v2] btrfs: remove unused inode argument from uncompress_inline() Byongho Lee
2015-05-21 14:45 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).