* [PATCH] Btrfs: fix a comment in inode.c:evict_inode_truncate_pages()
@ 2015-06-10 12:02 fdmanana
2015-06-10 13:46 ` Liu Bo
0 siblings, 1 reply; 2+ messages in thread
From: fdmanana @ 2015-06-10 12:02 UTC (permalink / raw
To: linux-btrfs; +Cc: Filipe Manana
From: Filipe Manana <fdmanana@suse.com>
The comment was not correct about the part where it says the endio
callback of the bio might have not yet been called - update it
to mention that by that time the endio callback execution might
still be in progress only.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
fs/btrfs/inode.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 855935f..a21ad34 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -4989,8 +4989,9 @@ static void evict_inode_truncate_pages(struct inode *inode)
/*
* Keep looping until we have no more ranges in the io tree.
* We can have ongoing bios started by readpages (called from readahead)
- * that didn't get their end io callbacks called yet or they are still
- * in progress ((extent_io.c:end_bio_extent_readpage()). This means some
+ * that have their endio callback (extent_io.c:end_bio_extent_readpage)
+ * still in progress (unlocked the pages in the bio but did not yet
+ * unlocked the ranges in the io tree). Therefore this means some
* ranges can still be locked and eviction started because before
* submitting those bios, which are executed by a separate task (work
* queue kthread), inode references (inode->i_count) were not taken
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Btrfs: fix a comment in inode.c:evict_inode_truncate_pages()
2015-06-10 12:02 [PATCH] Btrfs: fix a comment in inode.c:evict_inode_truncate_pages() fdmanana
@ 2015-06-10 13:46 ` Liu Bo
0 siblings, 0 replies; 2+ messages in thread
From: Liu Bo @ 2015-06-10 13:46 UTC (permalink / raw
To: fdmanana; +Cc: linux-btrfs, Filipe Manana
On Wed, Jun 10, 2015 at 01:02:12PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> The comment was not correct about the part where it says the endio
> callback of the bio might have not yet been called - update it
> to mention that by that time the endio callback execution might
> still be in progress only.
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Thanks,
-liubo
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
> fs/btrfs/inode.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 855935f..a21ad34 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -4989,8 +4989,9 @@ static void evict_inode_truncate_pages(struct inode *inode)
> /*
> * Keep looping until we have no more ranges in the io tree.
> * We can have ongoing bios started by readpages (called from readahead)
> - * that didn't get their end io callbacks called yet or they are still
> - * in progress ((extent_io.c:end_bio_extent_readpage()). This means some
> + * that have their endio callback (extent_io.c:end_bio_extent_readpage)
> + * still in progress (unlocked the pages in the bio but did not yet
> + * unlocked the ranges in the io tree). Therefore this means some
> * ranges can still be locked and eviction started because before
> * submitting those bios, which are executed by a separate task (work
> * queue kthread), inode references (inode->i_count) were not taken
> --
> 2.1.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-10 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10 12:02 [PATCH] Btrfs: fix a comment in inode.c:evict_inode_truncate_pages() fdmanana
2015-06-10 13:46 ` Liu Bo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).