From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix end of tree detection when searching for data extent ref
Date: Wed, 15 May 2024 07:50:49 +0930 [thread overview]
Message-ID: <551fca0e-b599-4c25-82a7-bd06ed64184f@gmx.com> (raw)
In-Reply-To: <d025098ef2c013545df5f37ef85128805a104571.1715699835.git.fdmanana@suse.com>
在 2024/5/15 00:56, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> At lookup_extent_data_ref() we are incorrectly checking if we are at the
> last slot of the last leaf in the extent tree. We are returning -ENOENT
> if btrfs_next_leaf() returns a value greater than 1, but btrfs_next_leaf()
> never returns anything greater than 1:
>
> 1) It returns < 0 on error;
>
> 2) 0 if there is a next leaf (or a new item was added to the end of the
> current leaf after releasing the path);
>
> 3) 1 if there are no more leaves (and no new items were added to the last
> leaf after releasing the path).
>
> So fix this by checking if the return value is greater than zero instead
> of being greater than one.
>
> Fixes: 1618aa3c2e01 ("btrfs: simplify return variables in lookup_extent_data_ref()")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/extent-tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 47d48233b592..3774c191e36d 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -477,7 +477,7 @@ static noinline int lookup_extent_data_ref(struct btrfs_trans_handle *trans,
> if (path->slots[0] >= nritems) {
> ret = btrfs_next_leaf(root, path);
> if (ret) {
> - if (ret > 1)
> + if (ret > 0)
> return -ENOENT;
> return ret;
> }
prev parent reply other threads:[~2024-05-14 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 15:26 [PATCH] btrfs: fix end of tree detection when searching for data extent ref fdmanana
2024-05-14 16:22 ` David Sterba
2024-05-14 22:20 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551fca0e-b599-4c25-82a7-bd06ed64184f@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).