From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Gerald Combs <gerald@wireshark.org>,
Developer support list for Wireshark
<wireshark-dev@wireshark.org>, Guy Harris <gharris@sonic.net>
Cc: linux-can@vger.kernel.org
Subject: Re: [Wireshark-dev] [PATCH 0/4] Wireshark SocketCAN updates
Date: Mon, 18 Mar 2024 20:15:32 +0100 [thread overview]
Message-ID: <0860439d-7810-438b-b532-54b517e2a0cd@hartkopp.net> (raw)
In-Reply-To: <09952070-5182-4d63-bb2b-0cf6cfe2053d@wireshark.org>
Hi Gerald,
thanks for the pointer and the excellent documentation!!
That was a 10 minutes job:
https://gitlab.com/wireshark/wireshark/-/merge_requests/14886
I assumed the Wireshark development process taking place on the mailing
list - but GitLab is even better. Happy review ;-)
Many thanks and best regards,
Oliver
On 2024-03-18 17:37, Gerald Combs wrote:
> Thanks for your contribution! Can you submit a merge request at
>
> https://gitlab.com/wireshark/wireshark/ ?
>
> Complete documentation on contributing code to Wireshark can be found in
> our Developer's Guide at
>
> https://www.wireshark.org/docs/wsdg_html/#ChSrcContribute
>
> On 3/18/24 3:46 AM, Oliver Hartkopp via Wireshark-dev wrote:
>> This patchset simplifies the CAN packet type detection as it focusses
>> on the rules to distiguish the different CAN CC/FD/XL frames from the
>> Linux kernel API.
>>
>> Additionally some more content is shown in the dissector and the
>> CAN CiA 611-1 definitions have been cleaned up and extended by CiA.
>>
>> Oliver Hartkopp (4):
>> socketcan: simplify CAN packet type detection
>> socketcan: display CANFD_FDF and CANXL_XLF flag content
>> socketcan: display len8dlc content for Classical CAN
>> socketcan: update CAN CiA 611-1 definitions
>>
>> epan/dissectors/packet-socketcan.c | 86 ++++++++++--------------------
>> epan/dissectors/packet-socketcan.h | 17 +++---
>> 2 files changed, 39 insertions(+), 64 deletions(-)
>>
>
prev parent reply other threads:[~2024-03-18 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 10:46 [PATCH 0/4] Wireshark SocketCAN updates Oliver Hartkopp
2024-03-18 10:46 ` [PATCH 1/4] socketcan: simplify CAN packet type detection Oliver Hartkopp
2024-03-18 10:46 ` [PATCH 2/4] socketcan: display CANFD_FDF and CANXL_XLF flag content Oliver Hartkopp
2024-03-18 10:46 ` [PATCH 3/4] socketcan: display len8dlc content for Classical CAN Oliver Hartkopp
2024-03-18 10:46 ` [PATCH 4/4] socketcan: update CAN CiA 611-1 definitions Oliver Hartkopp
2024-03-18 16:37 ` [Wireshark-dev] [PATCH 0/4] Wireshark SocketCAN updates Gerald Combs
2024-03-18 19:15 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0860439d-7810-438b-b532-54b517e2a0cd@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=gerald@wireshark.org \
--cc=gharris@sonic.net \
--cc=linux-can@vger.kernel.org \
--cc=wireshark-dev@wireshark.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).