From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Eric Stahl <ericstahl@limntech.com>
Cc: linux-can@vger.kernel.org, marm@hms-networks.de,
Vincent Mailhol <vincent.mailhol@gmail.com>,
socketcan@hms-networks.de, Florian Ferg <flfe@hms-networks.de>,
Peter Seiderer <ps.report@gmx.net>
Subject: Re: IXXAT CAN-IB2XX drivers
Date: Wed, 27 Sep 2023 08:53:43 +0200 [thread overview]
Message-ID: <20230927-rely-slicer-d36eabd3b04f-mkl@pengutronix.de> (raw)
In-Reply-To: <20bd5abf-5d0f-86a5-4774-a8ba33d6ca1b@limntech.com>
[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]
On 26.09.2023 23:10:52, Eric Stahl wrote:
> I was beginning to familiarize myself with the ix_active_can drivers
> for IXXAT CAN-IB2XX pci/pcie boards in an attempt to get IXXAT
> pci/pcie drivers into the kernel. I noticed that the device driver
> distributed by HMS
> (https://www.ixxat.com/docs/librariesprovider8/ixxat-english-new/pc-can-interfaces/linux-drivers/socketcan-linux.tgz)
> appears to be using the IFI CAN/CANFD core. There already appears to
> be a kernel driver (ifi_canfd_plat_driver) that leverages the IFI
> CAN/CANFD core. Should I continue to try to get the ix_active_can
> drivers into the kernel or should I try to leverage the existing
> ifi_canfd_plat_driver? If I should leverage the ifi_canfd_plat_driver,
> what approach should I take to get it compatible with the IXXAT
> pci/pcie cards?
I think it's best reusing the existing driver.
You can split the existing ifi_canfd_plat_probe() into a generic (i.e.
ifi_canfd_probe()) and a platform driver specific part. The PCIe and the
platform driver will alloc_candev() and fill out the bare minimum of
that structure and the call into the generic ifi_canfd_probe().
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-09-27 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 3:10 IXXAT CAN-IB2XX drivers Eric Stahl
2023-09-27 6:53 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927-rely-slicer-d36eabd3b04f-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=ericstahl@limntech.com \
--cc=flfe@hms-networks.de \
--cc=linux-can@vger.kernel.org \
--cc=marm@hms-networks.de \
--cc=ps.report@gmx.net \
--cc=socketcan@hms-networks.de \
--cc=vincent.mailhol@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).