Linux-Can Archive mirror
 help / color / mirror / Atom feed
* IXXAT CAN-IB2XX drivers
@ 2023-09-27  3:10 Eric Stahl
  2023-09-27  6:53 ` Marc Kleine-Budde
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Stahl @ 2023-09-27  3:10 UTC (permalink / raw
  To: linux-can
  Cc: marm, Marc Kleine-Budde, Vincent Mailhol, socketcan, Florian Ferg,
	Peter Seiderer

Hi,

I was beginning to familiarize myself with the ix_active_can drivers for 
IXXAT CAN-IB2XX pci/pcie boards in an attempt to get IXXAT pci/pcie 
drivers into the kernel. I noticed that the device driver distributed by 
HMS 
(https://www.ixxat.com/docs/librariesprovider8/ixxat-english-new/pc-can-interfaces/linux-drivers/socketcan-linux.tgz) 
appears to be using the IFI CAN/CANFD core. There already appears to be 
a kernel driver (ifi_canfd_plat_driver) that leverages the IFI CAN/CANFD 
core. Should I continue to try to get the ix_active_can drivers into the 
kernel or should I try to leverage the existing ifi_canfd_plat_driver? 
If I should leverage the ifi_canfd_plat_driver, what approach should I 
take to get it compatible with the IXXAT pci/pcie cards?

Thanks,

Eric


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: IXXAT CAN-IB2XX drivers
  2023-09-27  3:10 IXXAT CAN-IB2XX drivers Eric Stahl
@ 2023-09-27  6:53 ` Marc Kleine-Budde
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2023-09-27  6:53 UTC (permalink / raw
  To: Eric Stahl
  Cc: linux-can, marm, Vincent Mailhol, socketcan, Florian Ferg,
	Peter Seiderer

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

On 26.09.2023 23:10:52, Eric Stahl wrote:
> I was beginning to familiarize myself with the ix_active_can drivers
> for IXXAT CAN-IB2XX pci/pcie boards in an attempt to get IXXAT
> pci/pcie drivers into the kernel. I noticed that the device driver
> distributed by HMS
> (https://www.ixxat.com/docs/librariesprovider8/ixxat-english-new/pc-can-interfaces/linux-drivers/socketcan-linux.tgz)
> appears to be using the IFI CAN/CANFD core. There already appears to
> be a kernel driver (ifi_canfd_plat_driver) that leverages the IFI
> CAN/CANFD core. Should I continue to try to get the ix_active_can
> drivers into the kernel or should I try to leverage the existing
> ifi_canfd_plat_driver? If I should leverage the ifi_canfd_plat_driver,
> what approach should I take to get it compatible with the IXXAT
> pci/pcie cards?

I think it's best reusing the existing driver.

You can split the existing ifi_canfd_plat_probe() into a generic (i.e.
ifi_canfd_probe()) and a platform driver specific part. The PCIe and the
platform driver will alloc_candev() and fill out the bare minimum of
that structure and the call into the generic ifi_canfd_probe().

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-27  6:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27  3:10 IXXAT CAN-IB2XX drivers Eric Stahl
2023-09-27  6:53 ` Marc Kleine-Budde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).