From: Christoph Fritz <christoph.fritz@hexdev.de>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: Andreas Lauser <andreas.lauser@mercedes-benz.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 05/11] dt-bindings: net: can: Add serdev LIN bus dt bindings
Date: Thu, 02 May 2024 07:26:59 +0200 [thread overview]
Message-ID: <77d0b2c62aad02c7c6f291676673b672ab35528a.camel@hexdev.de> (raw)
In-Reply-To: <784d78a8-3809-4a53-a9f2-7d9682b82c58@kernel.org>
Hello Krzysztof,
thanks for your feedback, please see my answers below.
On Mon, 2024-04-22 at 09:54 +0200, Krzysztof Kozlowski wrote:
> On 22/04/2024 08:51, Christoph Fritz wrote:
> > Add documentation of device tree bindings for serdev UART LIN-Bus
> > devices equipped with LIN transceivers.
>
> A nit, subject: drop second/last, redundant "dt bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
OK
>
> >
> > Signed-off-by: Christoph Fritz <christoph.fritz@hexdev.de>
> > ---
> > .../bindings/net/can/linux,lin-serdev.yaml | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/can/linux,lin-serdev.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/linux,lin-serdev.yaml b/Documentation/devicetree/bindings/net/can/linux,lin-serdev.yaml
> > new file mode 100644
> > index 0000000000000..cb4e932ff249c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/can/linux,lin-serdev.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/can/linux,lin-serdev.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Linux serdev LIN-Bus Support
>
> This looks like Linux binding, but we expect here description of hardware.
OK
> > +
> > +description: |
> > + LIN-Bus support for UART devices equipped with LIN transceivers,
> > + utilizing the Serial Device Bus (serdev) interface.
>
> serdev is Linux thingy, AFAIR. Please describe the hardware.
OK, in v2 it will get changed to:
"""
LIN transceiver, mostly hard-wired to a serial device, used for
communication on a LIN bus.
"""
>
> > +
> > + For more details on an adapter, visit: https://hexdev.de/hexlin#tty
> > +
> > +properties:
> > + compatible:
> > + const: linux,lin-serdev
>
> Feels confusing. Your link describes real hardware, but you wrote
> bindings for software construct.
>
> If you add this to DT, then it is hard-wired on the board, right?
Yes, it is hard-wired.
> If so, how this could be a software construct?
It's not, but fairly generic, that's why I used 'linux,lin-serdev' as
compatible string. In v2 I'll change it to 'hexdev,lin-serdev'.
> > +
> > +required:
> > + - compatible
> > +
> > +examples:
> > + - |
> > + &uart2 {
>
> & does not make much sense here. I think you wanted it to be serial bus,
> so serial.
OK
>
> > + status = "okay";
>
> Drop, it was not disabled anywhere.
OK
>
>
> > + linbus {
> > + compatible = "linux,lin-serdev";
> > + };
> > + };
Let me address these points, fix warnings from dt_binding_check and
reroll in v2.
Thanks
-- Christoph
next prev parent reply other threads:[~2024-05-02 5:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 6:51 [PATCH 00/11] LIN Bus support for Linux Christoph Fritz
2024-04-22 6:51 ` [PATCH 01/11] can: Add LIN bus as CAN abstraction Christoph Fritz
2024-04-22 8:16 ` Jiri Slaby
2024-04-23 9:33 ` Christoph Fritz
2024-04-24 6:15 ` Jiri Slaby
2024-04-22 6:51 ` [PATCH 02/11] HID: hexLIN: Add support for USB LIN bus adapter Christoph Fritz
2024-04-22 8:21 ` Benjamin Tissoires
2024-04-25 20:49 ` Christoph Fritz
2024-04-22 6:51 ` [PATCH 03/11] tty: serdev: Add flag buffer aware receive_buf_fp() Christoph Fritz
2024-04-22 6:51 ` [PATCH 04/11] tty: serdev: Add method to enable break flags Christoph Fritz
2024-04-22 6:51 ` [PATCH 05/11] dt-bindings: net: can: Add serdev LIN bus dt bindings Christoph Fritz
2024-04-22 7:54 ` Krzysztof Kozlowski
2024-05-02 5:26 ` Christoph Fritz [this message]
2024-04-22 8:26 ` Rob Herring
2024-04-23 6:55 ` Krzysztof Kozlowski
2024-04-22 6:51 ` [PATCH 06/11] can: Add support for serdev LIN adapters Christoph Fritz
2024-04-22 6:51 ` [PATCH 07/11] can: lin: Add special frame id for rx offload config Christoph Fritz
2024-04-22 6:51 ` [PATCH 08/11] can: bcm: Add LIN answer offloading for responder mode Christoph Fritz
2024-04-22 6:51 ` [PATCH 09/11] can: lin: Handle rx offload config frames Christoph Fritz
2024-04-22 6:51 ` [PATCH 10/11] can: lin: Support setting LIN mode Christoph Fritz
2024-04-22 6:51 ` [PATCH 11/11] HID: hexLIN: Implement ability to update lin mode Christoph Fritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d0b2c62aad02c7c6f291676673b672ab35528a.camel@hexdev.de \
--to=christoph.fritz@hexdev.de \
--cc=andreas.lauser@mercedes-benz.com \
--cc=bentiss@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).