Linux-CIFS Archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org
Subject: [bug report] Avoiding reserved identifier violations
Date: Sat, 11 Oct 2025 16:05:18 +0200	[thread overview]
Message-ID: <06e01da1-cdc0-4be3-b74d-fe12da890c1a@web.de> (raw)

Hello,

I would like to point out once more that identifiers like the following
do eventually not fit to the expected naming convention of the C++ language standard.

* _CIFSKEY_H
  https://git.samba.org/?p=cifs-utils.git;a=blob;f=cifskey.h;h=00694456e7f8a574d50c998501fa441b4230b0bf;hb=1561527e4b6192f6d47b85ea670637f771f5d52c#l20

* _LIBUTIL_H
  https://git.samba.org/?p=cifs-utils.git;a=blob;f=util.h;h=2864130f9246a87bd2f5118636a727f5dcecc01d;hb=e18d42adddbea9178d93b6051132f9cdee4cc9e0#l25


Would you like to adjust your selection for unique names?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29

Regards,
Markus

                 reply	other threads:[~2025-10-11 14:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06e01da1-cdc0-4be3-b74d-fe12da890c1a@web.de \
    --to=markus.elfring@web.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).