Linux-CIFS Archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>, cocci@inria.fr
Cc: linux-cifs@vger.kernel.org
Subject: Re: [cocci] Improving source code parsing for “fs/smb/client/dir.c”?
Date: Mon, 13 Oct 2025 14:16:59 +0200	[thread overview]
Message-ID: <1865e9dc-c6aa-489d-8945-e5a29a470523@web.de> (raw)
In-Reply-To: <805f36f6-ea15-cbc9-f510-45856eb6f6d7@inria.fr>

>> …
>> bad: static int cifs_do_create(struct inode *inode, struct dentry *direntry, unsigned int xid,
>> …
>> fs/smb/client/dir.c:211: passed:#ifdef CONFIG_CIFS_ALLOW_INSECURE_LEGACY
>> fs/smb/client/dir.c:280: passed: 
>> …
>> nb good = 679,  nb passed = 7 =========> 0.72% passed
>> nb good = 679,  nb bad = 283 =========> 70.79% good or passed
>>
>>
>> Under which circumstances will data processing become better supported for such files?
>> https://elixir.bootlin.com/linux/v6.17.1/source/fs/smb/client/dir.c#L178-L455
> 
> If you want the problem to be solved, please make some effort to narrow it
> down to a smaller number of lines.  Like 5.

I guess that you can recognise remaining development challenges for the Coccinelle software.

Will the chances grow to support preprocessor directives like #ifdef and #endif better anyhow?

Regards,
Markus

  reply	other threads:[~2025-10-13 12:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 11:50 Improving source code parsing for “fs/smb/client/dir.c”? Markus Elfring
2025-10-13 12:04 ` [cocci] " Julia Lawall
2025-10-13 12:16   ` Markus Elfring [this message]
2025-10-13 13:05   ` Markus Elfring
2025-10-13 14:35   ` Markus Elfring
2025-10-13 14:49     ` Julia Lawall
2025-10-13 15:00       ` Markus Elfring
2025-10-13 15:47       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1865e9dc-c6aa-489d-8945-e5a29a470523@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@inria.fr \
    --cc=julia.lawall@inria.fr \
    --cc=linux-cifs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).