* [PATCH -next] smb: switch to use kmemdup_nul() helper
@ 2023-07-25 12:31 Yang Yingliang
2023-07-26 23:52 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2023-07-25 12:31 UTC (permalink / raw
To: linux-cifs; +Cc: linkinjeon, sfrench, senozhatsky, tom, yangyingliang
Use kmemdup_nul() helper instead of open-coding to
simplify the code.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
fs/smb/server/asn1.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/smb/server/asn1.c b/fs/smb/server/asn1.c
index cc6384f79675..4a4b2b03ff33 100644
--- a/fs/smb/server/asn1.c
+++ b/fs/smb/server/asn1.c
@@ -214,12 +214,10 @@ static int ksmbd_neg_token_alloc(void *context, size_t hdrlen,
{
struct ksmbd_conn *conn = context;
- conn->mechToken = kmalloc(vlen + 1, GFP_KERNEL);
+ conn->mechToken = kmemdup_nul(value, vlen, GFP_KERNEL);
if (!conn->mechToken)
return -ENOMEM;
- memcpy(conn->mechToken, value, vlen);
- conn->mechToken[vlen] = '\0';
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] smb: switch to use kmemdup_nul() helper
2023-07-25 12:31 [PATCH -next] smb: switch to use kmemdup_nul() helper Yang Yingliang
@ 2023-07-26 23:52 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2023-07-26 23:52 UTC (permalink / raw
To: Yang Yingliang; +Cc: linux-cifs, sfrench, senozhatsky, tom
2023-07-25 21:31 GMT+09:00, Yang Yingliang <yangyingliang@huawei.com>:
> Use kmemdup_nul() helper instead of open-coding to
> simplify the code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks for your patch!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-26 23:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 12:31 [PATCH -next] smb: switch to use kmemdup_nul() helper Yang Yingliang
2023-07-26 23:52 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).