Linux-CIFS Archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: cocci@inria.fr, linux-cifs@vger.kernel.org
Subject: Re: [cocci] Improving source code parsing for “fs/smb/client/dir.c”?
Date: Mon, 13 Oct 2025 20:04:37 +0800 (+08)	[thread overview]
Message-ID: <805f36f6-ea15-cbc9-f510-45856eb6f6d7@inria.fr> (raw)
In-Reply-To: <335b0fe9-313f-4e3d-a01d-1954f3c46489@web.de>

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]



On Mon, 13 Oct 2025, Markus Elfring wrote:

> Hello,
>
> I would like to point another questionable test result out
> (according to the software combination “Coccinelle 1.3.0”):
>
> Markus_Elfring@Sonne:…/Projekte/Coccinelle/janitor> /usr/bin/spatch --no-includes --parse-c fs/smb/client/dir.c
> …
> parse error
>  = File "fs/smb/client/dir.c", line 964, column 0, charpos = 25270
>   around = '',
>   whole content =
> badcount: 283
> …
> bad: static int cifs_do_create(struct inode *inode, struct dentry *direntry, unsigned int xid,
> …
> fs/smb/client/dir.c:211: passed:#ifdef CONFIG_CIFS_ALLOW_INSECURE_LEGACY
> fs/smb/client/dir.c:280: passed:#endif
> …
> nb good = 679,  nb passed = 7 =========> 0.72% passed
> nb good = 679,  nb bad = 283 =========> 70.79% good or passed
>
>
> Under which circumstances will data processing become better supported for such files?
> https://elixir.bootlin.com/linux/v6.17.1/source/fs/smb/client/dir.c#L178-L455

If you want the problem to be solved, please make some effort to narrow it
down to a smaller number of lines.  Like 5.

julia

  reply	other threads:[~2025-10-13 12:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 11:50 Improving source code parsing for “fs/smb/client/dir.c”? Markus Elfring
2025-10-13 12:04 ` Julia Lawall [this message]
2025-10-13 12:16   ` [cocci] " Markus Elfring
2025-10-13 13:05   ` Markus Elfring
2025-10-13 14:35   ` Markus Elfring
2025-10-13 14:49     ` Julia Lawall
2025-10-13 15:00       ` Markus Elfring
2025-10-13 15:47       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=805f36f6-ea15-cbc9-f510-45856eb6f6d7@inria.fr \
    --to=julia.lawall@inria.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@inria.fr \
    --cc=linux-cifs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).