From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>, cocci@inria.fr
Cc: linux-cifs@vger.kernel.org
Subject: Re: [cocci] Improving source code parsing for “fs/smb/client/dir.c”?
Date: Mon, 13 Oct 2025 16:35:07 +0200 [thread overview]
Message-ID: <8480276b-ee1e-454e-954f-b25890c79add@web.de> (raw)
In-Reply-To: <805f36f6-ea15-cbc9-f510-45856eb6f6d7@inria.fr>
> If you want the problem to be solved, please make some effort to narrow it
> down to a smaller number of lines. …
How do you think about to improve data processing for another source file example
like the following?
static int my_test_condition(void)
{
#ifdef MY_CONFIG_LEGACY_OPTION
if (0)
{
my_log("working?");
}
else
{
/* Test comment */
}
my_info:
if (0)
my_log("reminder!");
else
{
#else
{
#endif
my_log("special part");
}
return 0;
}
Questionable test result (according to the software combination “Coccinelle 1.3.0”):
Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> /usr/bin/spatch --parse-c test-ifdef-legacy3.c
…
PB: not found closing brace in fuzzy parsing
ERROR-RECOV: found sync '}' at line 23
…
parse error
= File "test-ifdef-legacy3.c", line 24, column 0, charpos = 282
around = '',
whole content =
badcount: 22
bad: static int my_test_condition(void)
…
bad: return 0;
BAD:!!!!! }
…
nb good = 0, nb passed = 3 =========> 12.00% passed
nb good = 0, nb bad = 22 =========> 12.00% good or passed
Will similar test cases trigger more desirable improvements?
Regards,
Markus
next prev parent reply other threads:[~2025-10-13 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 11:50 Improving source code parsing for “fs/smb/client/dir.c”? Markus Elfring
2025-10-13 12:04 ` [cocci] " Julia Lawall
2025-10-13 12:16 ` Markus Elfring
2025-10-13 13:05 ` Markus Elfring
2025-10-13 14:35 ` Markus Elfring [this message]
2025-10-13 14:49 ` Julia Lawall
2025-10-13 15:00 ` Markus Elfring
2025-10-13 15:47 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8480276b-ee1e-454e-954f-b25890c79add@web.de \
--to=markus.elfring@web.de \
--cc=cocci@inria.fr \
--cc=julia.lawall@inria.fr \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).