From: Paulo Alcantara <pc@manguebit.org>
To: Henrique Carvalho <henrique.carvalho@suse.com>,
Steve French <smfrench@gmail.com>
Cc: ronnie sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Bharath S M <bharathsm@microsoft.com>,
Enzo Matsumiya <ematsumiya@suse.de>,
Jay Shin <jaeshin@redhat.com>,
linux-cifs@vger.kernel.org
Subject: Re: [PATCH v4] smb: client: fix potential UAF in smb2_close_cached_fid()
Date: Sat, 08 Nov 2025 15:25:52 -0300 [thread overview]
Message-ID: <926cdc492899f9626612d5d881c34317@manguebit.org> (raw)
In-Reply-To: <7eba7884-3b54-4711-b5b3-5d82e1981acb@suse.com>
Henrique Carvalho <henrique.carvalho@suse.com> writes:
> Resending to include linux-cifs@vger.kernel.org.
>
> Since there were concerns about a potential deadlock in this path (from Enzo
> and copilot), I reworked the patch a bit.
>
> In theory the existing code is fine as long as the refcount invariant holds,
> but we've already been proven wrong in this area a few times. So I'd rather
> make the deadlock impossible and WARN if the invariant is violated
> instead of
> relying on it being perfect.
>
> @Paulo, what do you think about this?
Sounds good.
next prev parent reply other threads:[~2025-11-08 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <baf7ee5f-aa34-41f3-a00c-8e3b7686d566@suse.com>
2025-11-08 13:44 ` [PATCH v4] smb: client: fix potential UAF in smb2_close_cached_fid() Henrique Carvalho
2025-11-08 18:25 ` Paulo Alcantara [this message]
2025-11-03 22:52 Henrique Carvalho
2025-11-04 14:58 ` Steve French
2025-11-04 22:42 ` Steve French
2025-11-05 13:30 ` Henrique Carvalho
2025-11-05 16:16 ` Henrique Carvalho
[not found] ` <CAH2r5mvkefptGUvjarOmOW=hQA7_ZRFLwOk_jptOSAyzuMUGuw@mail.gmail.com>
2025-11-05 21:16 ` Henrique Carvalho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=926cdc492899f9626612d5d881c34317@manguebit.org \
--to=pc@manguebit.org \
--cc=bharathsm@microsoft.com \
--cc=ematsumiya@suse.de \
--cc=henrique.carvalho@suse.com \
--cc=jaeshin@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).