From: chenxiaosong@chenxiaosong.com
To: stfrench@microsoft.com, metze@samba.org, pali@kernel.org,
linkinjeon@kernel.org, smfrench@gmail.com, sfrench@samba.org,
senozhatsky@chromium.org, tom@talpey.com, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com,
bharathsm@microsoft.com, zhangguodong@kylinos.cn
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: [PATCH RESEND 01/22] smb/server: fix possible memory leak in smb2_read()
Date: Sun, 12 Oct 2025 23:22:26 +0800 [thread overview]
Message-ID: <9836A3F274B62345+20251012152247.2992573-2-chenxiaosong@chenxiaosong.com> (raw)
In-Reply-To: <20251012152247.2992573-1-chenxiaosong@chenxiaosong.com>
From: ZhangGuoDong <zhangguodong@kylinos.cn>
Memory leak occurs when ksmbd_vfs_read() fails.
Fix this by adding the missing kvfree().
Co-developed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: ZhangGuoDong <zhangguodong@kylinos.cn>
---
fs/smb/server/smb2pdu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index ab1d45fcebde..e81e615f322a 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -6824,6 +6824,7 @@ int smb2_read(struct ksmbd_work *work)
nbytes = ksmbd_vfs_read(work, fp, length, &offset, aux_payload_buf);
if (nbytes < 0) {
+ kvfree(aux_payload_buf);
err = nbytes;
goto out;
}
--
2.43.0
next parent reply other threads:[~2025-10-12 15:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251012152247.2992573-1-chenxiaosong@chenxiaosong.com>
2025-10-12 15:22 ` chenxiaosong [this message]
2025-10-12 15:22 ` [PATCH RESEND 02/22] smb/server: fix possible refcount leak in smb2_sess_setup() chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 03/22] smb: move some duplicate definitions to common/cifsglob.h chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 04/22] smb: move smb_version_values " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 05/22] smb: move get_rfc1002_len() " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 06/22] smb: move SMB1_PROTO_NUMBER " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 07/22] smb: move some duplicate definitions to common/smb2pdu.h chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 08/22] smb: move smb_sockaddr_in and smb_sockaddr_in6 " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 09/22] smb: move copychunk definitions " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 10/22] smb: move resume_key_ioctl_rsp " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 11/22] smb: move smb2_file_network_open_info " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 12/22] smb: move some duplicate definitions to common/cifspdu.h chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 13/22] smb: move file access permission bits " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 14/22] smb: move SMB frame " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 15/22] smb: move FILE_SYSTEM_ATTRIBUTE_INFO " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 16/22] smb: move FILE_SYSTEM_DEVICE_INFO " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 17/22] smb: move FILE_SYSTEM_INFO " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 18/22] smb: move FILE_DIRECTORY_INFO " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 19/22] smb: move FILE_FULL_DIRECTORY_INFO " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 20/22] smb: move FILE_BOTH_DIRECTORY_INFO " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 21/22] smb: move SEARCH_ID_FULL_DIR_INFO " chenxiaosong
2025-10-12 15:22 ` [PATCH RESEND 22/22] smb: move FILE_SYSTEM_POSIX_INFO " chenxiaosong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9836A3F274B62345+20251012152247.2992573-2-chenxiaosong@chenxiaosong.com \
--to=chenxiaosong@chenxiaosong.com \
--cc=bharathsm@microsoft.com \
--cc=chenxiaosong@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=pali@kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=stfrench@microsoft.com \
--cc=tom@talpey.com \
--cc=zhangguodong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).