From: Markus Elfring <Markus.Elfring@web.de>
To: Steve French <smfrench@gmail.com>,
Henrique Carvalho <henrique.carvalho@suse.com>,
linux-cifs@vger.kernel.org,
samba-technical <samba-technical@lists.samba.org>,
Bharath SM <bharathsm@microsoft.com>,
Paulo Alcantara <pc@manguebit.org>,
Pavel Shilovsky <pshilov@microsoft.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Steve French <sfrench@samba.org>, Tom Talpey <tom@talpey.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] smb: client: Move an error code assignment in smb3_init_transform_rq()
Date: Wed, 8 Oct 2025 23:00:12 +0200 [thread overview]
Message-ID: <99546145-8c6a-4e26-a787-b5c9bb0b8613@web.de> (raw)
In-Reply-To: <CAH2r5msZjL_krwN-nd1Ly3skxAHK9srJehPJ_vYXPLRFXpJ_yw@mail.gmail.com>
> Also when a patch doesn't shrink code, but even grows it by one line, and doesn't make it much clearer, it is probably not worth changing (it complicates future backports of real fixes in the future eg). Let's limit these to those that shrink code and make code clearer (or ideally fix potential bugs)
Do you insist to keep an extra initialisation for the local variable “rc”
despite of the implementation detail that the value “-ENOMEM” is needed
only for a single if branch here?
Regards,
Markus
prev parent reply other threads:[~2025-10-08 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 17:04 [PATCH] smb: client: Move an error code assignment in smb3_init_transform_rq() Markus Elfring
2025-10-08 17:17 ` Henrique Carvalho
2025-10-08 19:40 ` Markus Elfring
[not found] ` <CAH2r5msZjL_krwN-nd1Ly3skxAHK9srJehPJ_vYXPLRFXpJ_yw@mail.gmail.com>
2025-10-08 21:00 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99546145-8c6a-4e26-a787-b5c9bb0b8613@web.de \
--to=markus.elfring@web.de \
--cc=bharathsm@microsoft.com \
--cc=henrique.carvalho@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=pshilov@microsoft.com \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).