From: Meetakshi Setiya <meetakshisetiyaoss@gmail.com>
To: rajasimandalos@gmail.com
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
metze@samba.org, bharathsm@microsoft.com,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
Rajasi Mandal <rajasimandal@microsoft.com>
Subject: Re: [PATCH 2/9] smb: client: allow both 'lease' and 'nolease' mount options
Date: Mon, 13 Apr 2026 06:30:59 -0700 [thread overview]
Message-ID: <CAFTVevUOL5wjLjs2aVXP_0Wn627R=46NcKFWxRfAoN6bwuHmBQ@mail.gmail.com> (raw)
In-Reply-To: <20260409095926.905020-2-rajasimandalos@gmail.com>
Reviewed-by: Meetakshi Setiya <msetiya@microsoft.com>
On Thu, Apr 9, 2026 at 3:07 AM <rajasimandalos@gmail.com> wrote:
>
> From: Rajasi Mandal <rajasimandal@microsoft.com>
>
> Change the nolease mount option from fsparam_flag() to fsparam_flag_no()
> so that both 'lease' and 'nolease' are accepted as valid mount options.
>
> Previously, only 'nolease' was recognized. Passing 'lease' would fail
> with an unknown parameter error (or be silently ignored with 'sloppy').
>
> With this change:
> - 'nolease' disables lease requests (same behavior as before)
> - 'lease' explicitly enables lease requests
>
> This also renames the enum value from Opt_nolease to Opt_lease and uses
> result.negated to set ctx->no_lease, which is the standard pattern used
> by other flag_no options in the cifs mount option parser.
>
> Signed-off-by: Rajasi Mandal <rajasimandal@microsoft.com>
> ---
> fs/smb/client/fs_context.c | 6 +++---
> fs/smb/client/fs_context.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
> index 0f6c1eb8e274..e1bf7bad5be6 100644
> --- a/fs/smb/client/fs_context.c
> +++ b/fs/smb/client/fs_context.c
> @@ -80,7 +80,7 @@ const struct fs_parameter_spec smb3_fs_parameters[] = {
> fsparam_flag_no("forcegid", Opt_forcegid),
> fsparam_flag("noblocksend", Opt_noblocksend),
> fsparam_flag("noautotune", Opt_noautotune),
> - fsparam_flag("nolease", Opt_nolease),
> + fsparam_flag_no("lease", Opt_lease),
> fsparam_flag_no("hard", Opt_hard),
> fsparam_flag_no("soft", Opt_soft),
> fsparam_flag_no("perm", Opt_perm),
> @@ -1572,8 +1572,8 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,
> case Opt_noautotune:
> ctx->noautotune = 1;
> break;
> - case Opt_nolease:
> - ctx->no_lease = 1;
> + case Opt_lease:
> + ctx->no_lease = result.negated;
> break;
> case Opt_nosparse:
> ctx->no_sparse = 1;
> diff --git a/fs/smb/client/fs_context.h b/fs/smb/client/fs_context.h
> index 0b64fcb5d302..a80a5caff23c 100644
> --- a/fs/smb/client/fs_context.h
> +++ b/fs/smb/client/fs_context.h
> @@ -102,7 +102,7 @@ enum cifs_param {
> Opt_forcegid,
> Opt_noblocksend,
> Opt_noautotune,
> - Opt_nolease,
> + Opt_lease,
> Opt_nosparse,
> Opt_hard,
> Opt_soft,
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2026-04-13 13:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 9:59 [PATCH 1/9] smb: client: block non-reconfigurable option changes on remount rajasimandalos
2026-04-09 9:59 ` [PATCH 2/9] smb: client: allow both 'lease' and 'nolease' mount options rajasimandalos
2026-04-13 13:30 ` Meetakshi Setiya [this message]
2026-04-09 9:59 ` [PATCH 3/9] smb: client: sync tcon-level options on remount rajasimandalos
2026-04-17 14:29 ` Meetakshi Setiya
2026-04-09 9:59 ` [PATCH 4/9] smb: client: sync retrans " rajasimandalos
2026-04-09 9:59 ` [PATCH 5/9] smb: client: sync echo_interval " rajasimandalos
2026-04-22 4:42 ` [PATCH v2] " rajasimandalos
2026-04-09 9:59 ` [PATCH 6/9] smb: client: allow nolease option to be reconfigured " rajasimandalos
2026-04-22 5:06 ` [PATCH v2] " rajasimandalos
2026-04-22 8:36 ` Bharath SM
2026-04-22 15:29 ` Steve French
2026-04-09 9:59 ` [PATCH 7/9] smb: client: block cache=ro and cache=singleclient " rajasimandalos
2026-04-13 13:40 ` Meetakshi Setiya
2026-04-22 4:34 ` RAJASI MANDAL
2026-04-09 9:59 ` [PATCH 8/9] smb: client: fix domainauto remount by syncing domainname from session rajasimandalos
2026-04-09 9:59 ` [PATCH 9/9] smb: client: apply rasize on remount rajasimandalos
2026-04-13 13:29 ` Meetakshi Setiya
2026-04-13 7:32 ` [PATCH v2 1/9] smb: client: block non-reconfigurable option changes " Rajasi Mandal
2026-04-17 14:05 ` Meetakshi Setiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFTVevUOL5wjLjs2aVXP_0Wn627R=46NcKFWxRfAoN6bwuHmBQ@mail.gmail.com' \
--to=meetakshisetiyaoss@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=pc@manguebit.org \
--cc=rajasimandal@microsoft.com \
--cc=rajasimandalos@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).