From: Meetakshi Setiya <meetakshisetiyaoss@gmail.com>
To: rajasimandalos@gmail.com
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
metze@samba.org, bharathsm@microsoft.com,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
Rajasi Mandal <rajasimandal@microsoft.com>
Subject: Re: [PATCH 3/9] smb: client: sync tcon-level options on remount
Date: Fri, 17 Apr 2026 07:29:43 -0700 [thread overview]
Message-ID: <CAFTVevVYu3YkvhYxwiNJbQVpufMN33rpHQD8u_4g9G8zR59JwA@mail.gmail.com> (raw)
In-Reply-To: <20260409095926.905020-3-rajasimandalos@gmail.com>
Hi Rajasi,
Some nits:
On Thu, Apr 9, 2026 at 3:03 AM <rajasimandalos@gmail.com> wrote:
>
> From: Rajasi Mandal <rajasimandal@microsoft.com>
>
> Several mount options are stored on each cifs_tcon at mount time but
> smb3_reconfigure() only updates cifs_sb->ctx. A remount that changes
> any of these options silently has no effect because the runtime code
> reads from the tcon fields, not from the superblock context.
>
> The affected options and their tcon fields are:
> retry -> tcon->retry
> max_cached_dirs -> tcon->max_cached_dirs
>
> Add smb3_sync_tcon_opts() which walks the tlink_tree under
> tlink_tree_lock and propagates these values from ctx to every tcon
> under tc_lock. Call it from smb3_reconfigure() after the context has
> been updated.
>
> Signed-off-by: Rajasi Mandal <rajasimandal@microsoft.com>
> ---
> fs/smb/client/fs_context.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
> index e1bf7bad5be6..90e83f07c870 100644
> --- a/fs/smb/client/fs_context.c
> +++ b/fs/smb/client/fs_context.c
> @@ -1307,6 +1307,35 @@ static void smb3_sync_ses_chan_max(struct cifs_ses *ses, unsigned int max_channe
> spin_unlock(&ses->chan_lock);
> }
>
> +/*
> + * Synchronize tcon options that are derived from ctx across all tcons
> + * associated with this superblock. These fields are consulted at runtime
> + * (reconnect, I/O, unlink/rmdir) so remount needs to update the live
> + * tcons in addition to cifs_sb->ctx.
> + */
> +static void smb3_sync_tcon_opts(struct cifs_sb_info *cifs_sb,
> + struct smb3_fs_context *ctx)
> +{
> + struct rb_node *node;
> +
> + spin_lock(&cifs_sb->tlink_tree_lock);
> + for (node = rb_first(&cifs_sb->tlink_tree); node; node = rb_next(node)) {
> + struct tcon_link *tlink;
> + struct cifs_tcon *tcon;
Maybe declare these outside the loop?
> +
> + tlink = rb_entry(node, struct tcon_link, tl_rbnode);
> + tcon = tlink_tcon(tlink);
> + if (IS_ERR_OR_NULL(tcon))
> + continue;
> +
> + spin_lock(&tcon->tc_lock);
> + tcon->retry = ctx->retry;
> + tcon->max_cached_dirs = ctx->max_cached_dirs;
Would be good to add a comment that this will not resize the existing
cached dirents.
> + spin_unlock(&tcon->tc_lock);
> + }
> + spin_unlock(&cifs_sb->tlink_tree_lock);
> +}
> +
> static int smb3_reconfigure(struct fs_context *fc)
> {
> struct smb3_fs_context *ctx = smb3_fc2context(fc);
> @@ -1444,6 +1473,8 @@ static int smb3_reconfigure(struct fs_context *fc)
> if (!rc)
> rc = dfs_cache_remount_fs(cifs_sb);
> #endif
> + if (!rc)
> + smb3_sync_tcon_opts(cifs_sb, cifs_sb->ctx);
>
> return rc;
> }
> --
> 2.43.0
>
>
Other than that, it looks good to me.
Thanks
Meetakshi
next prev parent reply other threads:[~2026-04-17 14:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 9:59 [PATCH 1/9] smb: client: block non-reconfigurable option changes on remount rajasimandalos
2026-04-09 9:59 ` [PATCH 2/9] smb: client: allow both 'lease' and 'nolease' mount options rajasimandalos
2026-04-13 13:30 ` Meetakshi Setiya
2026-04-09 9:59 ` [PATCH 3/9] smb: client: sync tcon-level options on remount rajasimandalos
2026-04-17 14:29 ` Meetakshi Setiya [this message]
2026-04-09 9:59 ` [PATCH 4/9] smb: client: sync retrans " rajasimandalos
2026-04-09 9:59 ` [PATCH 5/9] smb: client: sync echo_interval " rajasimandalos
2026-04-22 4:42 ` [PATCH v2] " rajasimandalos
2026-04-09 9:59 ` [PATCH 6/9] smb: client: allow nolease option to be reconfigured " rajasimandalos
2026-04-22 5:06 ` [PATCH v2] " rajasimandalos
2026-04-22 8:36 ` Bharath SM
2026-04-22 15:29 ` Steve French
2026-04-09 9:59 ` [PATCH 7/9] smb: client: block cache=ro and cache=singleclient " rajasimandalos
2026-04-13 13:40 ` Meetakshi Setiya
2026-04-22 4:34 ` RAJASI MANDAL
2026-04-09 9:59 ` [PATCH 8/9] smb: client: fix domainauto remount by syncing domainname from session rajasimandalos
2026-04-09 9:59 ` [PATCH 9/9] smb: client: apply rasize on remount rajasimandalos
2026-04-13 13:29 ` Meetakshi Setiya
2026-04-13 7:32 ` [PATCH v2 1/9] smb: client: block non-reconfigurable option changes " Rajasi Mandal
2026-04-17 14:05 ` Meetakshi Setiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFTVevVYu3YkvhYxwiNJbQVpufMN33rpHQD8u_4g9G8zR59JwA@mail.gmail.com \
--to=meetakshisetiyaoss@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metze@samba.org \
--cc=pc@manguebit.org \
--cc=rajasimandal@microsoft.com \
--cc=rajasimandalos@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).