Linux-CIFS Archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Jeremy Allison <jra@samba.org>
Cc: Ralph Boehme <slow@samba.org>,
	samba-technical <samba-technical@lists.samba.org>,
	 CIFS <linux-cifs@vger.kernel.org>
Subject: Re: query fs info level 0x100
Date: Mon, 29 Apr 2024 22:30:21 -0500	[thread overview]
Message-ID: <CAH2r5msSmi7z0usFAU-BGctoApZthgqy6j9ZdghYRyifBNB60A@mail.gmail.com> (raw)
In-Reply-To: <Zi/UzF/guANa02KO@jeremy-HP-Z840-Workstation>

Worked for me.  You can add my Reviewed-by and Tested-by if you want.

On Mon, Apr 29, 2024 at 12:11 PM Jeremy Allison <jra@samba.org> wrote:
>
> On Mon, Apr 29, 2024 at 06:44:39PM +0200, Ralph Boehme wrote:
> >On 4/29/24 6:13 PM, Steve French wrote:
> >>But the (current Samba) server fails the level 100 (level 0x64 in hex)
> >>FS_POSIX_INFO with "STATUS_INVALID_ERROR_CLASS"
> >>which causes all xfstests to break since they can't verify the mount
> >>(e.g. with "stat -f").
> >>Nothing related to this on the client has changed, and ksmbd has
> >>always supported this so works fine there.
> >
> >ah, I broke it. Fix attached. Really embarrassing...
>
> Double embarrassing, I +1 reviewed it. So sorry for the bug :-(.



-- 
Thanks,

Steve

      reply	other threads:[~2024-04-30  3:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28 23:27 query fs info level 0x100 Steve French
2024-04-29  5:31 ` Ralph Boehme
2024-04-29 16:13   ` Steve French
2024-04-29 16:37     ` Stefan Metzmacher
2024-04-29 16:44     ` Ralph Boehme
2024-04-29 17:11       ` Jeremy Allison
2024-04-30  3:30         ` Steve French [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH2r5msSmi7z0usFAU-BGctoApZthgqy6j9ZdghYRyifBNB60A@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=jra@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=slow@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).