From: Steve French <smfrench@gmail.com>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: linux-cifs@vger.kernel.org, pc@manguebit.com,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
bharathsm@microsoft.com, henrique.carvalho@suse.com
Subject: Re: [PATCH 2/8] smb: client: compress: fix bad encoding on last LZ77 flag
Date: Sat, 18 Apr 2026 20:35:28 -0500 [thread overview]
Message-ID: <CAH2r5mt1_wE_9A_rJa=Z85kkg-KTZ4BEvMiM-b7c+Yaa5SjBaA@mail.gmail.com> (raw)
In-Reply-To: <20260413190713.283939-2-ematsumiya@suse.de>
merged into cifs-2.6.git for-next
On Mon, Apr 13, 2026 at 2:07 PM Enzo Matsumiya <ematsumiya@suse.de> wrote:
>
> End-of-stream flag could lead to UB because of int promotion
> (overwriting signed bit).
>
> Fix it by changing operand from '1' to '1UL'.
>
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> ---
> fs/smb/client/compress/lz77.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/compress/lz77.c b/fs/smb/client/compress/lz77.c
> index 16c7d8f3ef17..c1e7fada6e61 100644
> --- a/fs/smb/client/compress/lz77.c
> +++ b/fs/smb/client/compress/lz77.c
> @@ -216,7 +216,7 @@ noinline int lz77_compress(const void *src, u32 slen, void *dst, u32 *dlen)
> }
>
> flag <<= (32 - flag_count);
> - flag |= (1 << (32 - flag_count)) - 1;
> + flag |= (1UL << (32 - flag_count)) - 1;
> lz77_write32(flag_pos, flag);
>
> *dlen = dstp - dst;
> --
> 2.53.0
>
--
Thanks,
Steve
next prev parent reply other threads:[~2026-04-19 1:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 19:07 [PATCH 1/8] smb: client: compress: fix buffer overrun in lz77_compress() Enzo Matsumiya
2026-04-13 19:07 ` [PATCH 2/8] smb: client: compress: fix bad encoding on last LZ77 flag Enzo Matsumiya
2026-04-19 1:35 ` Steve French [this message]
2026-04-13 19:07 ` [PATCH 3/8] smb: client: compress: fix counting in LZ77 match finding Enzo Matsumiya
2026-04-13 19:07 ` [PATCH 4/8] smb: client: compress: increase LZ77_MATCH_MAX_DIST Enzo Matsumiya
2026-04-13 19:07 ` [PATCH 5/8] smb: client: compress: LZ77 optimizations Enzo Matsumiya
2026-04-13 19:07 ` [PATCH 6/8] smb: client: compress: add code docs to lz77.c Enzo Matsumiya
2026-04-13 19:07 ` [PATCH 7/8] smb: client: compress: add compress/common.h Enzo Matsumiya
2026-04-20 21:24 ` Nathan Chancellor
2026-04-20 21:31 ` Steve French
2026-04-13 19:07 ` [PATCH 8/8] smb: common: add SMB3_COMPRESS_MAX_ALGS Enzo Matsumiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mt1_wE_9A_rJa=Z85kkg-KTZ4BEvMiM-b7c+Yaa5SjBaA@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=ematsumiya@suse.de \
--cc=henrique.carvalho@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=ronniesahlberg@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).