* Question about NTLMSSP_NEGOTIATE_VERSION in NTLM messages
@ 2023-07-18 15:19 Roy Shterman
[not found] ` <CAH2r5mvgPSf=e7b7jXfY+v1bzJfmfAhdqBkkomKG5xn4xMa8Ug@mail.gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Roy Shterman @ 2023-07-18 15:19 UTC (permalink / raw
To: linux-cifs
Hi,
I see that in the commit bellow we added Version into the negotiate message:
commit 52d005337b2c94ab37273d9ad8382d4fb051defd
Author: Steve French <stfrench@microsoft.com>
Date: Wed Jan 19 22:00:29 2022 -0600
smb3: send NTLMSSP version information
For improved debugging it can be helpful to send version information
as other clients do during NTLMSSP negotiation. See protocol document
MS-NLMP section 2.2.1.1
Set the major and minor versions based on the kernel version, and the
BuildNumber based on the internal cifs.ko module version number,
and following the recommendation in the protocol documentation
(MS-NLMP section 2.2.10) we set the NTLMRevisionCurrent field to 15.
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Now if I understand correctly the server side should return in
negotiate flags the flags he got from the client and that it supports.
It means that in auth_message where we construct the negotiate flags
we will have the NTLMSSP_NEGOTIATE_VERSION flag as well although we
are not sending the version as part of the message.
Doesn't it contradict the MS-NLMP spec?
Thanks,
Roy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Fwd: Question about NTLMSSP_NEGOTIATE_VERSION in NTLM messages
[not found] ` <CAH2r5mvgPSf=e7b7jXfY+v1bzJfmfAhdqBkkomKG5xn4xMa8Ug@mail.gmail.com>
@ 2023-07-25 6:21 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2023-07-25 6:21 UTC (permalink / raw
To: CIFS
I have a patch for this now in cifs-2.6.git for-next. See
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=19826558210b9102a7d4681c91784d137d60d71b
On Tue, Jul 18, 2023 at 10:23 AM Roy Shterman <roy.shterman@gmail.com> wrote:
>
> Hi,
>
> I see that in the commit bellow we added Version into the negotiate message:
> commit 52d005337b2c94ab37273d9ad8382d4fb051defd
> Author: Steve French <stfrench@microsoft.com>
> Date: Wed Jan 19 22:00:29 2022 -0600
>
> smb3: send NTLMSSP version information
>
> For improved debugging it can be helpful to send version information
> as other clients do during NTLMSSP negotiation. See protocol document
> MS-NLMP section 2.2.1.1
>
> Set the major and minor versions based on the kernel version, and the
> BuildNumber based on the internal cifs.ko module version number,
> and following the recommendation in the protocol documentation
> (MS-NLMP section 2.2.10) we set the NTLMRevisionCurrent field to 15.
>
> Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
> Signed-off-by: Steve French <stfrench@microsoft.com>
>
> Now if I understand correctly the server side should return in
> negotiate flags the flags he got from the client and that it supports.
> It means that in auth_message where we construct the negotiate flags
> we will have the NTLMSSP_NEGOTIATE_VERSION flag as well although we
> are not sending the version as part of the message.
>
> Doesn't it contradict the MS-NLMP spec?
>
> Thanks,
> Roy
--
Thanks,
Steve
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-25 6:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-18 15:19 Question about NTLMSSP_NEGOTIATE_VERSION in NTLM messages Roy Shterman
[not found] ` <CAH2r5mvgPSf=e7b7jXfY+v1bzJfmfAhdqBkkomKG5xn4xMa8Ug@mail.gmail.com>
2023-07-25 6:21 ` Fwd: " Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).