From: Steve French <smfrench@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-cifs@vger.kernel.org, Steve French <sfrench@samba.org>,
linux-crypto@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Bharath SM <bharathsm@microsoft.com>
Subject: Re: [PATCH v2 0/4] smb: client: Use AES-CMAC library
Date: Sat, 18 Apr 2026 20:36:39 -0500 [thread overview]
Message-ID: <CAH2r5mu-zJa_N_NJERuOrAbS4RnKsaMTroZs6Nxdtd9CNGo-_w@mail.gmail.com> (raw)
In-Reply-To: <20260418221311.67583-1-ebiggers@kernel.org>
merged into cifs-2.6.git for-next pending additional testing and review
On Sat, Apr 18, 2026 at 5:13 PM Eric Biggers <ebiggers@kernel.org> wrote:
>
> This series updates the SMB client to use the AES-CMAC library functions
> that were recently added, instead of a "cmac(aes)" crypto_shash. As
> usual, this simplifies the code considerably and is much more efficient.
>
> These patches were originally sent as patches 8-11 of the series
> https://lore.kernel.org/r/20260218213501.136844-1-ebiggers@kernel.org/
> The only change from that version was adding tags and rebasing.
> I also added some microbenchmark results below.
>
> This is intended to be taken through the smb tree, either 7.1 or 7.2
> depending on maintainer preference.
>
> A few microbenchmarks that demonstrate improved performance:
>
> - Total cycles spent in generate_key() during SMB3 mount
> decreased from 20640 to 10780 (3 calls total).
>
> - Total cycles spent in smb3_calc_signature() during SMB3 mount
> decreased from 177620 to 73180 (32 calls & 4255 bytes total).
>
> - Total cycles spent in smb3_calc_signature() while writing 10MB file
> decreased from 27551180 to 26628360 (10 calls & 10001392 bytes total)
>
> - Total cycles spent in smb3_calc_signature() while reading 10MB file
> decreased from 28390900 to 27879340 (14 calls & 10001781 bytes total)
>
> Note that my "before" numbers were taken from current mainline which has
> my changes that made the "cmac(aes)" crypto_shash a bit faster as well.
> So the speedup vs v7.0 is actually even greater.
>
> Eric Biggers (4):
> smb: client: Use AES-CMAC library for SMB3 signature calculation
> smb: client: Remove obsolete cmac(aes) allocation
> smb: client: Make generate_key() return void
> smb: client: Drop 'allocate_crypto' arg from smb*_calc_signature()
>
> fs/smb/client/Kconfig | 2 +-
> fs/smb/client/cifs_unicode.c | 1 +
> fs/smb/client/cifsencrypt.c | 62 ++++++-------------
> fs/smb/client/cifsfs.c | 1 -
> fs/smb/client/cifsglob.h | 7 +--
> fs/smb/client/cifsproto.h | 3 -
> fs/smb/client/misc.c | 57 -----------------
> fs/smb/client/sess.c | 11 ----
> fs/smb/client/smb2proto.h | 1 -
> fs/smb/client/smb2transport.c | 113 +++++++++-------------------------
> 10 files changed, 53 insertions(+), 205 deletions(-)
>
>
> base-commit: 8541d8f725c673db3bd741947f27974358b2e163
> --
> 2.53.0
>
>
--
Thanks,
Steve
prev parent reply other threads:[~2026-04-19 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 22:13 [PATCH v2 0/4] smb: client: Use AES-CMAC library Eric Biggers
2026-04-18 22:13 ` [PATCH v2 1/4] smb: client: Use AES-CMAC library for SMB3 signature calculation Eric Biggers
2026-04-18 22:13 ` [PATCH v2 2/4] smb: client: Remove obsolete cmac(aes) allocation Eric Biggers
2026-04-18 22:13 ` [PATCH v2 3/4] smb: client: Make generate_key() return void Eric Biggers
2026-04-18 22:13 ` [PATCH v2 4/4] smb: client: Drop 'allocate_crypto' arg from smb*_calc_signature() Eric Biggers
2026-04-19 1:36 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mu-zJa_N_NJERuOrAbS4RnKsaMTroZs6Nxdtd9CNGo-_w@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=ardb@kernel.org \
--cc=bharathsm@microsoft.com \
--cc=ebiggers@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).